Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1679)

Issue 10832316: Handle invalid usage cache file path (Closed)

Created:
8 years, 4 months ago by tzik
Modified:
8 years, 4 months ago
Reviewers:
kinuko
CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

Handle invalid usage cache file path usage_file_path can be empty when a FileSystem is accessed after DeleteFileSystem call. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151692

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M webkit/fileapi/file_system_usage_cache.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tzik
8 years, 4 months ago (2012-08-15 12:05:44 UTC) #1
kinuko
lgtm http://codereview.chromium.org/10832316/diff/1/webkit/fileapi/file_system_usage_cache.cc File webkit/fileapi/file_system_usage_cache.cc (right): http://codereview.chromium.org/10832316/diff/1/webkit/fileapi/file_system_usage_cache.cc#newcode135 webkit/fileapi/file_system_usage_cache.cc:135: file_util::ReadFile(usage_file_path, buffer, kUsageFileSize)) indent looks weird?
8 years, 4 months ago (2012-08-15 12:07:38 UTC) #2
tzik
Thanks! http://codereview.chromium.org/10832316/diff/1/webkit/fileapi/file_system_usage_cache.cc File webkit/fileapi/file_system_usage_cache.cc (right): http://codereview.chromium.org/10832316/diff/1/webkit/fileapi/file_system_usage_cache.cc#newcode135 webkit/fileapi/file_system_usage_cache.cc:135: file_util::ReadFile(usage_file_path, buffer, kUsageFileSize)) On 2012/08/15 12:07:38, kinuko wrote: ...
8 years, 4 months ago (2012-08-15 12:15:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/10832316/4001
8 years, 4 months ago (2012-08-15 12:15:16 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 14:30:38 UTC) #5
Change committed as 151692

Powered by Google App Engine
This is Rietveld 408576698