sync/engine/apply_updates_command.cc - Issue 10832286: sync: Introduce control data types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/engine/apply_updates_command.cc

Issue 10832286: sync: Introduce control data types (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments (never tried to compile, possibly broken) Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/engine/apply_updates_command.cc

diff --git a/sync/engine/apply_updates_command.cc b/sync/engine/apply_updates_command.cc

index da8a1cc4c2e987d464445cfbef8bd63cd0be4513..c423656ff9268cffa1b6c353f4a1e0d514c91a11 100644

--- a/sync/engine/apply_updates_command.cc

+++ b/sync/engine/apply_updates_command.cc

@@ -36,6 +36,10 @@ std::set<ModelSafeGroup> ApplyUpdatesCommand::GetGroupsToChange(

GetGroupForModelType(it.Get(), session.routing_info()));

}

+ // The INTERNAL types are special. They have their own update routines,

Nicolas Zea 2012/08/20 20:44:28 INTERNAL -> CONTROL?

rlarocque 2012/08/22 23:46:24 Done.

+ // ApplyUpdatesCommand should not process them.

+ groups_with_unapplied_updates.erase(GROUP_CONTROL);

return groups_with_unapplied_updates;

}