Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Unified Diff: media/base/audio_bus.h

Issue 10832285: Switch OnMoreData() to use AudioBus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Comments. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/win/waveout_output_win.cc ('k') | media/base/limits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_bus.h
diff --git a/media/base/audio_bus.h b/media/base/audio_bus.h
index ea7e5f81a5fb8f1a8eba59ced6e8ae2fb0c91730..544f7cbdfd1b8710010ce27f7b12bd1906226c53 100644
--- a/media/base/audio_bus.h
+++ b/media/base/audio_bus.h
@@ -66,7 +66,8 @@ class MEDIA_EXPORT AudioBus {
void CopyTo(AudioBus* dest) const;
// Returns a raw pointer to the requested channel. Pointer is guaranteed to
- // have a 16-byte alignment.
+ // have a 16-byte alignment. Warning: Do not rely on having sane (i.e. not
+ // inf, nan, or between [-1.0, 1.0]) values in the channel data.
float* channel(int channel) { return channel_data_[channel]; }
const float* channel(int channel) const { return channel_data_[channel]; }
« no previous file with comments | « media/audio/win/waveout_output_win.cc ('k') | media/base/limits.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698