media/base/audio_bus.h - Issue 10832285: Switch OnMoreData() to use AudioBus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/audio_bus.h

Issue 10832285: Switch OnMoreData() to use AudioBus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments. Use actual frame count for PPAPI. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/audio_bus.h

diff --git a/media/base/audio_bus.h b/media/base/audio_bus.h

index ea7e5f81a5fb8f1a8eba59ced6e8ae2fb0c91730..544f7cbdfd1b8710010ce27f7b12bd1906226c53 100644

--- a/media/base/audio_bus.h

+++ b/media/base/audio_bus.h

@@ -66,7 +66,8 @@ class MEDIA_EXPORT AudioBus {

void CopyTo(AudioBus* dest) const;

// Returns a raw pointer to the requested channel. Pointer is guaranteed to

- // have a 16-byte alignment.

+ // have a 16-byte alignment. Warning: Do not rely on having sane (i.e. not

+ // inf, nan, or between [-1.0, 1.0]) values in the channel data.

float* channel(int channel) { return channel_data_[channel]; }

const float* channel(int channel) const { return channel_data_[channel]; }