Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: media/audio/audio_device_thread.cc

Issue 10832285: Switch OnMoreData() to use AudioBus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Comments. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « media/audio/audio_device_thread.h ('k') | media/audio/audio_input_device.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/audio/audio_device_thread.h" 5 #include "media/audio/audio_device_thread.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 samples_per_ms_), 185 samples_per_ms_),
186 shared_memory_(memory, false), 186 shared_memory_(memory, false),
187 memory_length_(memory_length) { 187 memory_length_(memory_length) {
188 CHECK_NE(bytes_per_ms_, 0); // Catch division by zero early. 188 CHECK_NE(bytes_per_ms_, 0); // Catch division by zero early.
189 CHECK_NE(samples_per_ms_, 0); 189 CHECK_NE(samples_per_ms_, 0);
190 } 190 }
191 191
192 AudioDeviceThread::Callback::~Callback() {} 192 AudioDeviceThread::Callback::~Callback() {}
193 193
194 void AudioDeviceThread::Callback::InitializeOnAudioThread() { 194 void AudioDeviceThread::Callback::InitializeOnAudioThread() {
195 DCHECK(!audio_bus_.get());
196
197 MapSharedMemory(); 195 MapSharedMemory();
198 DCHECK(shared_memory_.memory() != NULL); 196 DCHECK(shared_memory_.memory() != NULL);
199
200 // TODO(dalecurtis): Instead of creating a new AudioBus and memcpy'ing into
201 // the shared memory we should wrap the shared memory.
202 audio_bus_ = AudioBus::Create(audio_parameters_);
203 } 197 }
204 198
205 } // namespace media. 199 } // namespace media.
OLDNEW
« no previous file with comments | « media/audio/audio_device_thread.h ('k') | media/audio/audio_input_device.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698