Fixes for handling of MockDBusThreadManager::GetSystemBus().

Fixes for handling of MockDBusThreadManager::GetSystemBus().

BUG=131915
TEST=NetworkScreenTest.* and number of other tests should start passing in BVT CrOS tests

[satorux1, 2012-08-11 23:00:07]

Thank you for fixing these tests!

LGTM with nits

http://codereview.chromium.org/10832258/diff/1/chrome/browser/chromeos/blueto...
File chrome/browser/chromeos/bluetooth/bluetooth_device.cc (right):

http://codereview.chromium.org/10832258/diff/1/chrome/browser/chromeos/blueto...
chrome/browser/chromeos/bluetooth/bluetooth_device.cc:257: agent_.reset(NULL);
nit: you could do agent_.reset();

http://codereview.chromium.org/10832258/diff/1/chrome/browser/chromeos/settin...
File chrome/browser/chromeos/settings/signed_settings_helper_unittest.cc
(right):

http://codereview.chromium.org/10832258/diff/1/chrome/browser/chromeos/settin...
chrome/browser/chromeos/settings/signed_settings_helper_unittest.cc:49:
EXPECT_CALL(*mock_dbus_thread_manager, GetSystemBus())
mock_dbus_thread_manager -> mock_dbus_thread_manager_

http://codereview.chromium.org/10832258/diff/1/chrome/browser/chromeos/settin...
File chrome/browser/chromeos/settings/signed_settings_unittest.cc (right):

http://codereview.chromium.org/10832258/diff/1/chrome/browser/chromeos/settin...
chrome/browser/chromeos/settings/signed_settings_unittest.cc:121:
EXPECT_CALL(*mock_dbus_thread_manager, GetSystemBus())
mock_dbus_thread_manager -> mock_dbus_thread_manager_

[commit-bot: I haz the power, 2012-08-13 05:52:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/10832258/1

[zel, 2012-08-13 05:52:25]

On 2012/08/11 23:00:07, satorux1 wrote:
> Thank you for fixing these tests!
> 
> LGTM with nits
> 
>
http://codereview.chromium.org/10832258/diff/1/chrome/browser/chromeos/blueto...
> File chrome/browser/chromeos/bluetooth/bluetooth_device.cc (right):
> 
>
http://codereview.chromium.org/10832258/diff/1/chrome/browser/chromeos/blueto...
> chrome/browser/chromeos/bluetooth/bluetooth_device.cc:257: agent_.reset(NULL);
> nit: you could do agent_.reset();
> 
>
http://codereview.chromium.org/10832258/diff/1/chrome/browser/chromeos/settin...
> File chrome/browser/chromeos/settings/signed_settings_helper_unittest.cc
> (right):
> 
>
http://codereview.chromium.org/10832258/diff/1/chrome/browser/chromeos/settin...
> chrome/browser/chromeos/settings/signed_settings_helper_unittest.cc:49:
> EXPECT_CALL(*mock_dbus_thread_manager, GetSystemBus())
> mock_dbus_thread_manager -> mock_dbus_thread_manager_
> 
>
http://codereview.chromium.org/10832258/diff/1/chrome/browser/chromeos/settin...
> File chrome/browser/chromeos/settings/signed_settings_unittest.cc (right):
> 
>
http://codereview.chromium.org/10832258/diff/1/chrome/browser/chromeos/settin...
> chrome/browser/chromeos/settings/signed_settings_unittest.cc:121:
> EXPECT_CALL(*mock_dbus_thread_manager, GetSystemBus())
> mock_dbus_thread_manager -> mock_dbus_thread_manager_

will take care for nits when I get back in the office

[commit-bot: I haz the power, 2012-08-13 06:20:46]

Try job failure for 10832258-1 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[satorux1, 2012-08-13 06:43:10]

The nits are causing compile failures. :P
 I'll take care of this on behalf tomorrow.

[satorux1, 2012-08-13 20:35:18]

Done: http://codereview.chromium.org/10854121/