Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 10832247: chromeos: Add UMA stats for launcher and app list. (Closed)

Created:
8 years, 4 months ago by xiyuan
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

chromeos: Add UMA stats for launcher and app list. Add the following UMA stats: - Launcher_ClickOnAppListButton Count clicks on launcher's app list button. - Launcher_ClickOnApp Count clicks on apps in launcher bar (including Chrome). - AppList_ClickOnApp Count clicks on apps in app list bubble. - AppList_Search Count search + open result in app list. - AppList_ClickOnAppFromSearch Count clicks on apps in app list search results. BUG=137358 TEST=Verify the added UMA stats work as expected. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151156

Patch Set 1 #

Patch Set 2 : use RecordAction #

Total comments: 1

Patch Set 3 : sort UserMetricsAction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
M ash/launcher/launcher_view.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M ash/shell_delegate.h View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_view_delegate.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/app_list/search_builder.cc View 1 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ash/chrome_shell_delegate.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/tools/chromeactions.txt View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xiyuan
8 years, 4 months ago (2012-08-10 16:43:51 UTC) #1
sky
How come you're going with histograms instead of user actions?
8 years, 4 months ago (2012-08-10 19:04:34 UTC) #2
xiyuan
On 2012/08/10 19:04:34, sky wrote: > How come you're going with histograms instead of user ...
8 years, 4 months ago (2012-08-10 20:12:39 UTC) #3
sky
LGTM http://codereview.chromium.org/10832247/diff/5001/ash/shell_delegate.h File ash/shell_delegate.h (right): http://codereview.chromium.org/10832247/diff/5001/ash/shell_delegate.h#newcode48 ash/shell_delegate.h:48: UMA_LAUNCHER_CLICK_ON_APPLIST_BUTTON, Can you sort all of these.
8 years, 4 months ago (2012-08-10 22:22:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10832247/5004
8 years, 4 months ago (2012-08-10 22:36:34 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-10 23:54:06 UTC) #6
Change committed as 151156

Powered by Google App Engine
This is Rietveld 408576698