chrome/common/extensions/docs/examples/apps/cycler/cycler.html - Issue 10832191: Major revision of page cycler UI.

Side by Side Diff: chrome/common/extensions/docs/examples/apps/cycler/cycler.html

Issue 10832191: Major revision of page cycler UI. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Newer version with requested decomposition into separate sources Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/examples/apps/cycler/capture_tab.js ('K') | « chrome/common/extensions/docs/examples/apps/cycler/cycler.css ('k') | chrome/common/extensions/docs/examples/apps/cycler/cycler_data.js » ('j') | chrome/common/extensions/docs/examples/apps/cycler/cycler_data.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html5>
	Jeffrey Yasskin 2012/08/15 01:03:59 Isn't this supposed to be "<!doctype html>"? http: Isn't this supposed to be "<!doctype html>"? http://developers.whatwg.org/syntax.html#the-doctype clintstaley 2012/08/15 23:54:20 Thot I needed the HTML5 to support the spinner, bu Show quoted text On 2012/08/15 01:03:59, Jeffrey Yasskin wrote: > Isn't this supposed to be "<!doctype html>"? > http://developers.whatwg.org/syntax.html#the-doctype Thot I needed the HTML5 to support the spinner, but evidently not. Fixed. Jeffrey Yasskin 2012/08/16 20:19:31 <!doctype html> actually asks for HTML5. Show quoted text On 2012/08/15 23:54:20, clintstaley wrote: > On 2012/08/15 01:03:59, Jeffrey Yasskin wrote: > > Isn't this supposed to be "<!doctype html>"? > > http://developers.whatwg.org/syntax.html#the-doctype > > Thot I needed the HTML5 to support the spinner, but evidently not. Fixed. <!doctype html> actually asks for HTML5.
	2

	3 <!-- Copyright (c) 2012 The Chromium Authors. All rights reserved.

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file. -->

	6

	7 <html>

	8

	9 <head>

	10 <title>Page Cycler</title>

	11 <link rel='stylesheet' type='text/css' href='cycler.css'/>

	12 </head>

	13

	14 <body>

	15

	16 <div id='page'>

	17 <div class='row'>

	18 <div id='tab-navigator column'>

	19 <div class='row'>

	20 <img id='header-icon' src='cycler_icon.png' height='30' height='30'/>

	21 <h1 id='header'>Cycler</h1>

	22 </div>

	23 <div id='capture-tab-label' class='tab-label selected'>

	24 <a>Capture</a>

	25 </div>

	26 <div id='playback-tab-label' class='tab-label'>

	27 <a>Playback</a>

	28 </div>

	29 </div>

	30

	31 <div id='tab-wrapper'>

	32 <div id='capture-tab'>

	33 <div class='column'>

	34 <h1>Capture</h1>

	35 <div class='divider'></div>

	36 <h2>Name:</h2>

	37 <input class='indent' id='capture-name' type='text'

	38 class='name-combo'/>
	Jeffrey Yasskin 2012/08/15 01:03:59 Don't use two class attributes. Don't use two class attributes. clintstaley 2012/08/15 23:54:20 Done. Show quoted text On 2012/08/15 01:03:59, Jeffrey Yasskin wrote: > Don't use two class attributes. Done.
	39 <h2>URLs:</h2>

	40 <div class='indent'>

	41 Enter the URLs to capture, one URL per line.<br/>

	42 <textarea id='capture-urls' class='url-list'></textarea>

	43 </div>

	44 <button id='do-capture' class='gapped'>Capture!</button>

	45 </div>

	46 </div>

	47

	48 <div id='playback-tab' hidden>

	49 <div class='column'>

	50 <h1>Playback</h1>

	51 <div class='divider'> </div>

	52 <div id="no-captures" hidden>

	53 <h2>No captures available. Create new ones via Capture tab.</h2>

	54 </div>

	55 <div id='yes-captures'>

	56 <div class='column'>

	57 <h2>Capture:</h2>

	58 <select id='playback-name' class='indent name-combo'>

	59 <option value='' disabled selected>Choose a capture</option>

	60 </select>

	61 </div>

	62 <div id='playback-details' class='gapped'>

	63 <div class='column gapped'>

	64 <h2>URLs:</h2>

	65 <textarea id='playback-urls' class='indent url-list'></textarea>

	66 </div>

	67 <h2>Playback Options:</h2>

	68 <div class='row gapped'>

	69 <div class='indent sub-label'>Repetitions:</div>

	70 <input id='playback-repeats' type='number' min='1' max='100'

	71 value='1'/>

	72 </div>

	73 <div class='row gapped'>

	74 <div class='indent sub-label'>Install Extension:</div>

	75 <input id='playback-extension' type='text' />
	Jeffrey Yasskin 2012/08/15 01:03:59 This should be a file control, right? Or can those This should be a file control, right? Or can those not select directories? I don't see any use of the playback-browse button. How do you plan to use it? clintstaley 2012/08/15 23:54:20 These are for a later CL. Trying to do this in ph Show quoted text On 2012/08/15 01:03:59, Jeffrey Yasskin wrote: > This should be a file control, right? Or can those not select directories? > > I don't see any use of the playback-browse button. How do you plan to use it? These are for a later CL. Trying to do this in phases since we've been asked to get feedback incrementally. The plan would be to relay a directory of an unpacked extension, yes, which would in turn be the argument of a load-extension commandline argument in the subbrowser Jeffrey Yasskin 2012/08/16 20:19:31 Delaying the implementation sounds good to me. I r Show quoted text On 2012/08/15 23:54:20, clintstaley wrote: > On 2012/08/15 01:03:59, Jeffrey Yasskin wrote: > > This should be a file control, right? Or can those not select directories? > > > > I don't see any use of the playback-browse button. How do you plan to use it? > > These are for a later CL. Trying to do this in phases since we've been asked to > get feedback incrementally. The plan would be to relay a directory of an > unpacked extension, yes, which would in turn be the argument of a load-extension > commandline argument in the subbrowser Delaying the implementation sounds good to me. I realized that, even if a file input doesn't support selecting directories, you can have the user select the manifest.json file, and use getParent() to get the right DirectoryEntry to pass to the playback API.
	76 <button id='playback-browse'>Browse..</button>

	77 </div>

	78 <div class='row gapped'>

	79 <button id='do-playback'>Playback</button>

	80 <button id='do-delete'>Delete</button>

	81 </div>

	82 </div>

	83 </div>

	84 </div>

	85 </div>

	86 </div>

	87 </div>

	88

	89 <div id='popup' hidden>

	90 <div id='popup-box' style='column'>

	91 <div id='popup-content'>

	92 When in the course of human events it<br/>

	93 becomes necessary for one people<br/>

	94 to dissolve...

	95 </div>

	96 <button id='do-popup-dismiss' class='gapped'>Dismiss</button>

	97 </div>

	98 </div>

	99 </div>

	100

	101 <script type='text/javascript' src='cycler_data.js'></script>

	102 <script type='text/javascript' src='capture_tab.js'></script>

	103 <script type='text/javascript' src='playback_tab.js'></script>

	104 <script type='text/javascript' src='cycler_ui.js'></script>

	105 </body>

	106 </html>

OLD	NEW