chrome/browser/favicon/favicon_handler.cc - Issue 10832128: Convert FaviconStatus::bitmap from SkBitmap to gfx::Image.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_handler.cc

Issue 10832128: Convert FaviconStatus::bitmap from SkBitmap to gfx::Image. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tests? Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_handler.cc

diff --git a/chrome/browser/favicon/favicon_handler.cc b/chrome/browser/favicon/favicon_handler.cc

index e1f087cb07f6cda91bb7e1b5eb62c8f291d9c861..1da634c9af984ece421a93faed2c4120b41b3f9d 100644

--- a/chrome/browser/favicon/favicon_handler.cc

+++ b/chrome/browser/favicon/favicon_handler.cc

@@ -236,7 +236,7 @@ void FaviconHandler::UpdateFavicon(NavigationEntry* entry,

if (!image)

return;

- entry->GetFavicon().bitmap = *image->ToSkBitmap();

+ entry->GetFavicon().image = *image;

delegate_->NotifyFaviconUpdated();

}