Allow writing browser_tests that involve a restart. The way to do this:

Allow writing browser_tests that involve a restart. The way to do this:

IN_PROC_BROWSER_TEST_F(Foo, PRE_Bar) {
  do something
}

IN_PROC_BROWSER_TEST_F(Foo, Bar) {
  verify something persisted from before
}

This is recursive, so PRE_PRE_Bar works.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150096

[jam, 2012-08-02 05:49:11]

Scott: here's an implementation based on your suggestion. I'm open to
suggestions on the prefix's name.

[sky, 2012-08-02 15:21:55]

LGTM. Is there anything special you need to do for sharding?

http://codereview.chromium.org/10832106/diff/14002/content/test/test_launcher.cc
File content/test/test_launcher.cc (right):

http://codereview.chromium.org/10832106/diff/14002/content/test/test_launcher...
content/test/test_launcher.cc:307: std::string pre_test_name = test_name;
move 307/308 inside if (test_case)

http://codereview.chromium.org/10832106/diff/14002/content/test/test_launcher...
content/test/test_launcher.cc:313: std::string test_name =
test_info->test_case_name();
nit: use a different name here so you aren't shadowing the test_name parameter.

[jam, 2012-08-05 21:44:02]

On 2012/08/02 15:21:55, sky wrote:
> LGTM. Is there anything special you need to do for sharding?

it's already handled. because of the change at line 486, the tests starting with
PRE_ get ignored when running through the tests (either for sharding, or for
normal operation). Only when the test that has  PRE_ version runs do we look for
PRE_ versions.

http://codereview.chromium.org/10832106/diff/14002/content/test/test_launcher.cc
File content/test/test_launcher.cc (right):

http://codereview.chromium.org/10832106/diff/14002/content/test/test_launcher...
content/test/test_launcher.cc:307: std::string pre_test_name = test_name;
On 2012/08/02 15:21:55, sky wrote:
> move 307/308 inside if (test_case)

Done.