chrome/browser/extensions/webstore_installer.cc - Issue 10832105: Ensure that the WebstoreInstaller is always deleted on the UI thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 10832105: Ensure that the WebstoreInstaller is always deleted on the UI thread (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_installer.cc

diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc

index c8975d123f5503927cb7dfb06977cfd160e75165..1dfb39f0c05d43c8f03559d18b0761c14cc6438a 100644

--- a/chrome/browser/extensions/webstore_installer.cc

+++ b/chrome/browser/extensions/webstore_installer.cc

@@ -188,6 +188,7 @@ WebstoreInstaller::WebstoreInstaller(Profile* profile,

download_url_ = GetWebstoreInstallURL(id, flags & FLAG_INLINE_INSTALL ?

kInlineInstallSource : kDefaultInstallSource);

+ CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

registrar_.Add(this, chrome::NOTIFICATION_CRX_INSTALLER_DONE,

content::NotificationService::AllSources());

registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_INSTALLED,