Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 10832086: Update extensions OWNERS. (Closed)

Created:
8 years, 4 months ago by bryeung
Modified:
8 years, 4 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, pfeldman
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Patch Set 3 : review comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -15 lines) Patch
A + chrome/browser/chromeos/extensions/OWNERS View 1 2 chunks +1 line, -6 lines 1 comment Download
M chrome/browser/extensions/OWNERS View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/common/extensions/OWNERS View 1 1 chunk +1 line, -4 lines 0 comments Download
M chrome/renderer/extensions/OWNERS View 1 2 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bryeung
8 years, 4 months ago (2012-07-31 17:40:09 UTC) #1
Mihai Parparita -not on Chrome
https://chromiumcodereview.appspot.com/10832086/diff/1/chrome/browser/extensions/OWNERS File chrome/browser/extensions/OWNERS (right): https://chromiumcodereview.appspot.com/10832086/diff/1/chrome/browser/extensions/OWNERS#newcode6 chrome/browser/extensions/OWNERS:6: # chrome/browser/chromeos/extensions/OWNERS There is another copy at chrome/common/extensions/OWNERS. https://chromiumcodereview.appspot.com/10832086/diff/1/chrome/browser/extensions/OWNERS#newcode9 ...
8 years, 4 months ago (2012-07-31 17:42:36 UTC) #2
bryeung
ptal
8 years, 4 months ago (2012-07-31 17:45:34 UTC) #3
Mihai Parparita -not on Chrome
LGTM
8 years, 4 months ago (2012-07-31 17:46:33 UTC) #4
Nico
owners lgtm stamp if mihai says it's ok +pfeldman fyi
8 years, 4 months ago (2012-07-31 17:53:16 UTC) #5
hshi1
http://codereview.chromium.org/10832086/diff/9001/chrome/browser/chromeos/extensions/OWNERS File chrome/browser/chromeos/extensions/OWNERS (right): http://codereview.chromium.org/10832086/diff/9001/chrome/browser/chromeos/extensions/OWNERS#newcode14 chrome/browser/chromeos/extensions/OWNERS:14: yoz@chromium.org I'm also trying to add a few owners ...
8 years, 4 months ago (2012-07-31 17:59:31 UTC) #6
bryeung
8 years, 4 months ago (2012-07-31 18:01:20 UTC) #7
Sorry: this is already landed.

Bryan

On Tue, Jul 31, 2012 at 1:59 PM,  <hshi@chromium.org> wrote:
>
>
http://codereview.chromium.org/10832086/diff/9001/chrome/browser/chromeos/ext...
> File chrome/browser/chromeos/extensions/OWNERS (right):
>
>
http://codereview.chromium.org/10832086/diff/9001/chrome/browser/chromeos/ext...
> chrome/browser/chromeos/extensions/OWNERS:14: yoz@chromium.org
> I'm also trying to add a few owners in a separate review URL
> (http://codereview.chromium.org/10828086/)
>
> Could you add a separate section for chromeOS specific owners with
> tbarzic@, satorux@, zelidrag@. thanks.
>
> http://codereview.chromium.org/10832086/

Powered by Google App Engine
This is Rietveld 408576698