chrome/test/functional/webrtc_test_base.py - Issue 10832084: Fixed race condition in media_stream_infobar.py.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/functional/webrtc_test_base.py

Issue 10832084: Fixed race condition in media_stream_infobar.py. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 #!/usr/bin/env python

	2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

	3 # Use of this source code is governed by a BSD-style license that can be

	4 # found in the LICENSE file.

	5

	6 import pyauto

	7
	Nirnimesh 2012/07/31 20:10:09 need another blank line here need another blank line here phoglund_chromium 2012/08/01 07:08:39 Done. Show quoted text On 2012/07/31 20:10:09, Nirnimesh wrote: > need another blank line here Done.
	8 class WebrtcTestBase(pyauto.PyUITest):

	9 """This base class provides helpers for getUserMedia calls."""

	10

	11 def _WaitForGetUserMediaResult(self, tab_index):
	Nirnimesh 2012/07/31 20:10:09 Public methods should not have _ prefix Public methods should not have _ prefix phoglund_chromium 2012/08/01 07:08:39 Done. Show quoted text On 2012/07/31 20:10:09, Nirnimesh wrote: > Public methods should not have _ prefix Done.
	12 def HasResult():

	13 return self._GetUserMediaResult(tab_index) != 'not-called-yet'

	14 self.assertTrue(self.WaitUntil(HasResult),

	15 msg='Timed out while waiting for getUserMedia callback.')

	16

	17 def _GetUserMediaResult(self, tab_index):

	18 return self.ExecuteJavascript(

	19 'obtainGetUserMediaResult()', tab_index=tab_index)

OLD	NEW

« no previous file with comments | « chrome/test/functional/webrtc_call.py ('k') | no next file » | no next file with comments »