Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 10832081: Modifications to get skia headers compiling on iOS. (Closed)

Created:
8 years, 4 months ago by rohitrao (ping after 24h)
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Modifications to get skia headers compiling on iOS. This is a barebones implementation of the skia target in skia.gyp. iOS will not use a full skia implementation, but it will use an occasional header here and there. Those headers require an implementation of SkDebugf_FileLine(), so this CL adds a barebones skia target that simply compiles skia/ext/google_logging.cc. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149193

Patch Set 1 #

Patch Set 2 : Comment. #

Total comments: 1

Patch Set 3 : Moved ios block. #

Total comments: 1

Patch Set 4 : Remove redundant condition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M skia/skia.gyp View 1 2 3 2 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stuartmorgan
LGTM otherwise http://codereview.chromium.org/10832081/diff/2001/skia/skia.gyp File skia/skia.gyp (right): http://codereview.chromium.org/10832081/diff/2001/skia/skia.gyp#newcode932 skia/skia.gyp:932: [ 'OS == "ios"', { How about ...
8 years, 4 months ago (2012-07-31 13:57:53 UTC) #1
rohitrao (ping after 24h)
+Nico for review and OWNERS approval.
8 years, 4 months ago (2012-07-31 14:01:18 UTC) #2
noyau (Ping after 24h)
http://codereview.chromium.org/10832081/diff/4002/skia/skia.gyp File skia/skia.gyp (right): http://codereview.chromium.org/10832081/diff/4002/skia/skia.gyp#newcode1015 skia/skia.gyp:1015: [ 'OS == "mac" and OS != "ios"', { ...
8 years, 4 months ago (2012-07-31 14:08:19 UTC) #3
Nico
lgtm after addressing noyau's comment
8 years, 4 months ago (2012-07-31 14:10:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rohitrao@chromium.org/10832081/7002
8 years, 4 months ago (2012-07-31 14:18:41 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 15:52:05 UTC) #6
Change committed as 149193

Powered by Google App Engine
This is Rietveld 408576698