[Chromoting] Let the Windows host policy watcher read string-valued policies.

remoting/host/policy_hack/policy_watcher_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Most of this code is copied from various classes in
 // src/chrome/browser/policy. In particular, look at
 //
 //   configuration_policy_provider_delegate_win.{h,cc}
 //   configuration_policy_loader_win.{h,cc}
 //
@@ skipping 94 matching lines @@
             machine_policy_changed_event_.handle(), this)) {
       LOG(WARNING) << "Failed to start watch for machine policy change event";
       machine_policy_watcher_failed_ = true;
      }
 
     if (user_policy_watcher_failed_ || machine_policy_watcher_failed_) {
       ScheduleFallbackReloadTask();
     }
   }
 
+  bool GetRegistryPolicyString(const string16& value_name,

[alexeypa (please no reviews), 2012/07/30 21:27:06]

Mixture of string16 and std::string looks strange. Especially because
ASCIIToUTF16 is used below to get UTF-16 encoded name.

[simonmorris, 2012/07/30 22:08:17]

Done.

+                               std::string* result) const {
+    std::wstring value;
+    RegKey policy_key(HKEY_LOCAL_MACHINE, kRegistrySubKey, KEY_READ);
+    if (policy_key.ReadValue(value_name.c_str(), &value) == ERROR_SUCCESS) {

[alexeypa (please no reviews), 2012/07/30 21:27:06]

It should be UTF16ToWide(value_name).c_str(). I think it is better to stick to
UTF8 in this case.

[simonmorris, 2012/07/30 22:08:17]

Done.

+      *result = WideToUTF8(value);
+      return true;
+    }
+
+    if (policy_key.Open(HKEY_CURRENT_USER, kRegistrySubKey, KEY_READ) ==
+      ERROR_SUCCESS) {
+      if (policy_key.ReadValue(value_name.c_str(), &value) == ERROR_SUCCESS) {
+        *result = WideToUTF8(value);
+        return true;
+      }
+    }
+    return false;
+  }
+
   bool GetRegistryPolicyInteger(const string16& value_name,
                                 uint32* result) const {
     DWORD value = 0;
     RegKey policy_key(HKEY_LOCAL_MACHINE, kRegistrySubKey, KEY_READ);
     if (policy_key.ReadValueDW(value_name.c_str(), &value) == ERROR_SUCCESS) {
       *result = value;
       return true;
     }
 
     if (policy_key.Open(HKEY_CURRENT_USER, kRegistrySubKey, KEY_READ) ==
@@ skipping 19 matching lines @@
     base::DictionaryValue* policy = new base::DictionaryValue();
 
     for (int i = 0; i < kBooleanPolicyNamesNum; ++i) {
       const char* policy_name = kBooleanPolicyNames[i];
       bool bool_value;
       const string16 name(ASCIIToUTF16(policy_name));
       if (GetRegistryPolicyBoolean(name, &bool_value)) {
         policy->SetBoolean(policy_name, bool_value);
       }
     }
-    // TODO(simonmorris): Read policies whose names are in kStringPolicyNames.
-
+    for (int i = 0; i < kStringPolicyNamesNum; ++i) {
+      const char* policy_name = kStringPolicyNames[i];
+      std::string string_value;
+      const string16 name(ASCIIToUTF16(policy_name));
+      if (GetRegistryPolicyString(name, &string_value)) {

[alexeypa (please no reviews), 2012/07/30 21:27:06]

nit: Why don't pass ASCIIToUTF16(policy_name) directly to the call?

[simonmorris, 2012/07/30 22:08:17]

Done.

+        policy->SetString(policy_name, string_value);
+      }
+    }
     return policy;
   }
 
   // Post a reload notification and update the watch machinery.
   void Reload() {
     DCHECK(OnPolicyWatcherThread());
     SetupWatches();
     scoped_ptr<DictionaryValue> new_policy(Load());
     UpdatePolicies(new_policy.get());
   }
@@ skipping 16 matching lines @@
   bool machine_policy_watcher_failed_;
 };
 
 PolicyWatcher* PolicyWatcher::Create(
     scoped_refptr<base::SingleThreadTaskRunner> task_runner) {
   return new PolicyWatcherWin(task_runner);
 }
 
 }  // namespace policy_hack
 }  // namespace remoting