Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: lib/unittest/map_matchers.dart

Issue 10832058: Improved the way we generate mismatch descriptions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/unittest/interfaces.dart ('k') | lib/unittest/matcher.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/unittest/map_matchers.dart
===================================================================
--- lib/unittest/map_matchers.dart (revision 10002)
+++ lib/unittest/map_matchers.dart (working copy)
@@ -12,7 +12,7 @@
const _ContainsValue(this._value);
- bool matches(item) => item.containsValue(_value);
+ bool matches(item, MatchState matchState) => item.containsValue(_value);
Description describe(Description description) =>
description.add('contains value ').addDescriptionOf(_value);
}
@@ -30,22 +30,25 @@
const _ContainsMapping(this._key, Matcher this._valueMatcher);
- bool matches(item) =>
- item.containsKey(_key) && _valueMatcher.matches(item[_key]);
+ bool matches(item, MatchState matchState) =>
+ item.containsKey(_key) &&
+ _valueMatcher.matches(item[_key], matchState);
Description describe(Description description) {
return description.add('contains pair ').addDescriptionOf(_key).
add(' => ').addDescriptionOf(_valueMatcher);
}
- Description describeMismatch(item, Description mismatchDescription) {
+ Description describeMismatch(item, Description mismatchDescription,
+ MatchState matchState, bool verbose) {
if (!item.containsKey(_key)) {
return mismatchDescription.addDescriptionOf(item).
add(" doesn't contain key ").addDescriptionOf(_key);
} else {
mismatchDescription.add(' contains key ').addDescriptionOf(_key).
add(' but with value ');
- _valueMatcher.describeMismatch(item[_key], mismatchDescription);
+ _valueMatcher.describeMismatch(item[_key], mismatchDescription,
+ matchState, verbose);
return mismatchDescription;
}
}
« no previous file with comments | « lib/unittest/interfaces.dart ('k') | lib/unittest/matcher.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698