Issue 10832054: Removing --host-binary parameter in preparation to the coming me2me host refactoring.

Issue 10832054: Removing --host-binary parameter in preparation to the coming me2me host refactoring. (Closed)

Created:
8 years, 4 months ago by alexeypa (please no reviews)

Modified:
8 years, 4 months ago

Reviewers:
simonmorris

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removing --host-binary parameter in preparation to the coming me2me host refactoring. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149298

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback. #

Patch Set 3 : rebased #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -35 lines)			Patch
M	remoting/host/installer/chromoting.wxs	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/sas_injector_win.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	remoting/host/win/host_service.h	View	1 2	2 chunks	+0 lines, -4 lines	0 comments	Download
M	remoting/host/win/host_service.cc	View	1 2	5 chunks	+1 line, -15 lines	0 comments	Download
M	remoting/host/win/wts_session_process_launcher.h	View	1 2	3 chunks	+1 line, -7 lines	0 comments	Download
M	remoting/host/win/wts_session_process_launcher.cc	View	1 2	6 chunks	+17 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

simonmorris

lgtm with optional suggestion. http://codereview.chromium.org/10832054/diff/1/remoting/host/wts_session_process_launcher_win.cc File remoting/host/wts_session_process_launcher_win.cc (right): http://codereview.chromium.org/10832054/diff/1/remoting/host/wts_session_process_launcher_win.cc#newcode258 remoting/host/wts_session_process_launcher_win.cc:258: if (!PathService::Get(base::FILE_EXE, &exe_path)) { You ...

8 years, 4 months ago (2012-07-27 22:08:56 UTC) #2

alexeypa (please no reviews)

http://codereview.chromium.org/10832054/diff/1/remoting/host/wts_session_process_launcher_win.cc File remoting/host/wts_session_process_launcher_win.cc (right): http://codereview.chromium.org/10832054/diff/1/remoting/host/wts_session_process_launcher_win.cc#newcode258 remoting/host/wts_session_process_launcher_win.cc:258: if (!PathService::Get(base::FILE_EXE, &exe_path)) { On 2012/07/27 22:08:56, simonmorris wrote: ...

8 years, 4 months ago (2012-07-27 22:35:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10832054/10001

8 years, 4 months ago (2012-07-31 21:21:08 UTC) #4

Change committed as 149298

Expand Messages | Collapse Messages