src/trusted/service_runtime/linux/nacl_bootstrap_args.c - Issue 10832040: Support 64-bit reserved_at_zero value nacl-side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/service_runtime/linux/nacl_bootstrap_args.c

Issue 10832040: Support 64-bit reserved_at_zero value nacl-side (Closed) Base URL: http://git.chromium.org/native_client/src/native_client.git@master

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/nonnacl_util/sel_ldr_launcher_standalone.cc ('K') | « src/trusted/service_runtime/linux/nacl_bootstrap.c ('k') | src/trusted/service_runtime/linux/reserved_at_zero.c » ('j') | tools/toolchain_tester/toolchain_config.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/service_runtime/linux/nacl_bootstrap_args.c

diff --git a/src/trusted/service_runtime/linux/nacl_bootstrap_args.c b/src/trusted/service_runtime/linux/nacl_bootstrap_args.c

index 71f9a1d771eb9bf1451fc835b4eadb7b402babd7..fc561518162a317ace74a026330d69c3fe43e325 100644

--- a/src/trusted/service_runtime/linux/nacl_bootstrap_args.c

+++ b/src/trusted/service_runtime/linux/nacl_bootstrap_args.c

@@ -13,8 +13,8 @@

* and reserved_at_zero and updates argc and argv to act as though

* these arguments were not passed. For example, the command

- * nacl_helper_bootstrap program \

- * --r_debug=0xXXXXXXXXXXXXXXXX --reserved_at_zero=0xXXXXXXXX program_arg

+ * nacl_helper_bootstrap program --r_debug=0xXXXXXXXXXXXXXXXX \

+ * --reserved_at_zero=0xXXXXXXXXXXXXXXXX program_arg

* will result in the following argc and argv structure for program after

* running throughg the bootstrapper:

@@ -22,7 +22,7 @@

* argc: 4

* argv[0]: program

* argv[1]: --r_debug=0xXXXXXXXXXXXXXXXX

- * argv[2]: --reserved_at_zero=0xXXXXXXXX

+ * argv[2]: --reserved_at_zero=0xXXXXXXXXXXXXXXXX

* argv[3]: program_arg

* After program calls NaClHandleBootstrapArgs, the argc and argv structure