Support 64-bit reserved_at_zero value nacl-side

Allow for 64-bit reserved_at_zero parameter

This change will make the x86-32 sandbox on Linux non-zero-based until this change and the change at http://codereview.chromium.org/10826039/ are committed in Chromium.  Also, on Atom, performance will be temporarily reduced but not broken.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2927
TEST=trybots

Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=9337

[Austin Benson, 2012-07-27 21:07:52]

An analogous change to this one will be made in the Chrome repo (although that
change will be much smaller).

[Mark Seaborn, 2012-07-30 18:51:12]

LGTM, but: will this require a change on the Chromium side at the same time as
the nacl_revision update?

http://codereview.chromium.org/10832040/diff/1/SConstruct
File SConstruct (right):

http://codereview.chromium.org/10832040/diff/1/SConstruct#newcode1186
SConstruct:1186: template_digits = 'X'*16
Nit: spaces around '*', please

http://codereview.chromium.org/10832040/diff/1/run.py
File run.py (right):

http://codereview.chromium.org/10832040/diff/1/run.py#newcode228
run.py:228: template_digits = 'X'*16
Same nit: spaces around '*', please

http://codereview.chromium.org/10832040/diff/1/src/trusted/nonnacl_util/sel_l...
File src/trusted/nonnacl_util/sel_ldr_launcher_standalone.cc (right):

http://codereview.chromium.org/10832040/diff/1/src/trusted/nonnacl_util/sel_l...
src/trusted/nonnacl_util/sel_ldr_launcher_standalone.cc:63:
command->push_back("--r_debug=0x" + kTemplateDigits);
You could avoid a runtime concatenation by inlining kTemplateDigits into this
string, or by #defining this as you do in nacl_bootstrap.c.

http://codereview.chromium.org/10832040/diff/1/tools/toolchain_tester/toolcha...
File tools/toolchain_tester/toolchain_config.py (right):

http://codereview.chromium.org/10832040/diff/1/tools/toolchain_tester/toolcha...
tools/toolchain_tester/toolchain_config.py:62: TEMPLATE_DIGITS = 'X'*16
Same nit about spaces

[Mark Seaborn, 2012-07-30 19:14:03]

On 2012/07/30 18:51:12, Mark Seaborn wrote:
> LGTM, but: will this require a change on the Chromium side at the same
> time as the nacl_revision update?

Can you add a note to the commit message that this will make the x86-32 sandbox
non-zero-based on Linux until both this and
http://codereview.chromium.org/10826039/ are committed in Chromium, and that
this will reduce performance on Atom temporarily but not break anything?

Also, maybe you could test that zero-based x86-32 still works in Chromium after
these changes?

Mark

[Austin Benson, 2012-07-31 23:24:12]

http://codereview.chromium.org/10832040/diff/1/SConstruct
File SConstruct (right):

http://codereview.chromium.org/10832040/diff/1/SConstruct#newcode1186
SConstruct:1186: template_digits = 'X'*16
On 2012/07/30 18:51:12, Mark Seaborn wrote:
> Nit: spaces around '*', please

Done.

http://codereview.chromium.org/10832040/diff/1/run.py
File run.py (right):

http://codereview.chromium.org/10832040/diff/1/run.py#newcode228
run.py:228: template_digits = 'X'*16
On 2012/07/30 18:51:12, Mark Seaborn wrote:
> Same nit: spaces around '*', please

Done.

http://codereview.chromium.org/10832040/diff/1/src/trusted/nonnacl_util/sel_l...
File src/trusted/nonnacl_util/sel_ldr_launcher_standalone.cc (right):

http://codereview.chromium.org/10832040/diff/1/src/trusted/nonnacl_util/sel_l...
src/trusted/nonnacl_util/sel_ldr_launcher_standalone.cc:63:
command->push_back("--r_debug=0x" + kTemplateDigits);
On 2012/07/30 18:51:12, Mark Seaborn wrote:
> You could avoid a runtime concatenation by inlining kTemplateDigits into this
> string, or by #defining this as you do in nacl_bootstrap.c.

Inlined.

http://codereview.chromium.org/10832040/diff/1/tools/toolchain_tester/toolcha...
File tools/toolchain_tester/toolchain_config.py (right):

http://codereview.chromium.org/10832040/diff/1/tools/toolchain_tester/toolcha...
tools/toolchain_tester/toolchain_config.py:62: TEMPLATE_DIGITS = 'X'*16
On 2012/07/30 18:51:12, Mark Seaborn wrote:
> Same nit about spaces

Done.

[commit-bot: I haz the power, 2012-08-01 00:29:21]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/arbenson@google.com/10832040/1019

[commit-bot: I haz the power, 2012-08-01 02:42:18]

Change committed as 9337