Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6141)

Unified Diff: chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Issue 10832035: Switch from SignedSettings to DeviceSettingsService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: once more? Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/chrome_browser_main_chromeos.cc
diff --git a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
index e57a174593821d12e72368cf35bd2e7afe446cd9..99993420749270b2b87aed77590e831bf76c09a7 100644
--- a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
+++ b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
@@ -49,8 +49,8 @@
#include "chrome/browser/chromeos/power/screen_lock_observer.h"
#include "chrome/browser/chromeos/power/user_activity_notifier.h"
#include "chrome/browser/chromeos/power/video_activity_notifier.h"
-#include "chrome/browser/chromeos/settings/ownership_service.h"
-#include "chrome/browser/chromeos/settings/session_manager_observer.h"
+#include "chrome/browser/chromeos/settings/device_settings_service.h"
+#include "chrome/browser/chromeos/settings/owner_key_util.h"
#include "chrome/browser/chromeos/system/statistics_provider.h"
#include "chrome/browser/chromeos/system_key_event_listener.h"
#include "chrome/browser/chromeos/upgrade_detector_chromeos.h"
@@ -290,9 +290,11 @@ void ChromeBrowserMainPartsChromeos::PostMainMessageLoopStart() {
chromeos::CrosDBusService::Initialize();
- // Initialize the session manager observer so that we'll take actions
- // per signals sent from the session manager.
- session_manager_observer_.reset(new chromeos::SessionManagerObserver);
+ // Initialize the device settings service so that we'll take actions per
+ // signals sent from the session manager.
+ chromeos::DeviceSettingsService::Get()->Initialize(
+ chromeos::DBusThreadManager::Get()->GetSessionManagerClient(),
+ chromeos::OwnerKeyUtil::Create());
chromeos::disks::DiskMountManager::Initialize();
cryptohome::AsyncMethodCaller::Initialize();
@@ -344,7 +346,7 @@ void ChromeBrowserMainPartsChromeos::PreProfileInit() {
chromeos::BootTimesLoader::Get()->RecordChromeMainStats();
// Trigger prefetching of ownership status.
- chromeos::OwnershipService::GetSharedInstance()->Prewarm();
+ chromeos::DeviceSettingsService::Get()->Load();
// -- This used to be in ChromeBrowserMainParts::PreMainMessageLoopRun()
// -- just before CreateProfile().
@@ -503,9 +505,11 @@ void ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() {
if (chromeos::CrosNetworkChangeNotifierFactory::GetInstance())
chromeos::CrosNetworkChangeNotifierFactory::GetInstance()->Shutdown();
+ // Tell DeviceSettingsService to stop talking to session_manager.
+ chromeos::DeviceSettingsService::Get()->Shutdown();
+
// We should remove observers attached to D-Bus clients before
// DBusThreadManager is shut down.
- session_manager_observer_.reset();
screen_lock_observer_.reset();
resume_observer_.reset();
brightness_observer_.reset();

Powered by Google App Engine
This is Rietveld 408576698