Add const accessors to URLRequest and UploadData.

net/url_request/url_request.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_H_
 #define NET_URL_REQUEST_URL_REQUEST_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 395 matching lines @@
   //
   // This method may be called only after calling EnableChunkedUpload().
   void AppendChunkToUpload(const char* bytes,
                            int bytes_len,
                            bool is_last_chunk);
 
   // Set the upload data directly.
   void set_upload(UploadData* upload);
 
   // Get the upload data directly.
+  const UploadData* get_upload() const;

[gavinp, 2012/07/27 20:28:56]

Hrm, I wonder why this method name doesn't meet our coding standard: normally
hacker_style methods should only be inline simple getters.

[vabr (Chromium), 2012/07/28 20:37:09]

Well, I don't know, just copied the style from the non-const getter :). As you
suggest the _mutable name again in hacker_style I understand you don't want me
to change it. If you do, let me know, I can set-up a separate CL for that.
Alternatively to renaming, we could also inline these functions, as there indeed
are just simple getters.

   UploadData* get_upload();

[gavinp, 2012/07/27 20:28:56]

get_upload_mutable() here, too?

[vabr (Chromium), 2012/07/28 20:37:09]

Done.

 
   // Returns true if the request has a non-empty message body to upload.
   bool has_upload() const;
 
   // Set an extra request header by ID or name.  These methods may only be
   // called before Start() is called.  It is an error to call it later.
   void SetExtraRequestHeaderById(int header_id, const std::string& value,
                                  bool overwrite);
   void SetExtraRequestHeaderByName(const std::string& name,
                                    const std::string& value, bool overwrite);
@@ skipping 388 matching lines @@
   base::TimeTicks creation_time_;
 
   scoped_ptr<const base::debug::StackTrace> stack_trace_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequest);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_H_