Add const accessors to URLRequest and UploadData.

Add const accessors to URLRequest and UploadData.

These const accessors are needed in my other CL 10694055.

The accessors are very simple, so I duplicated the code rather than
const-casting the const accessor to implement the non-const.

BUG=139600
TEST=N/A (no fix & no new feature)
TBR=jianli@chromium.org,darin@chromium.org,joaodasilva@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148906

[vabr (Chromium), 2012-07-25 08:29:38]

Hi Gavin,

Could you please review this?

Vaclav

[vabr (Chromium), 2012-07-26 20:53:01]

On 2012/07/25 08:29:38, vabr (Chromium) wrote:
> Hi Gavin,
> 
> Could you please review this?
> 
> Vaclav

Hi Gavin,

A ping just in case my previous e-mail got lost. But no pressure :).

Thanks,

Vaclav

[gavinp, 2012-07-27 20:28:56]

Sorry for being a bit pokey!

LGTM. I've made some style suggestions that could improve this.

Also, when referencing another CL like http://codereview.chromium.org/10694055 ,
it's very polite to provide a link to make checking it out a bit easier.

http://codereview.chromium.org/10832003/diff/1/net/base/upload_data.h
File net/base/upload_data.h (right):

http://codereview.chromium.org/10832003/diff/1/net/base/upload_data.h#newcode230
net/base/upload_data.h:230: std::vector<Element>* elements() {
A suggestion: can we rename this one elements_mutable()?  Having both versions
overloaded is acceptable within our coding standard, but distinguishing them
does help readability.

http://codereview.chromium.org/10832003/diff/1/net/url_request/url_request.h
File net/url_request/url_request.h (right):

http://codereview.chromium.org/10832003/diff/1/net/url_request/url_request.h#...
net/url_request/url_request.h:416: const UploadData* get_upload() const;
Hrm, I wonder why this method name doesn't meet our coding standard: normally
hacker_style methods should only be inline simple getters.

http://codereview.chromium.org/10832003/diff/1/net/url_request/url_request.h#...
net/url_request/url_request.h:417: UploadData* get_upload();
get_upload_mutable() here, too?

[vabr (Chromium), 2012-07-28 20:37:09]

Thanks Gavin for the review.
I did the re-naming you suggested, owners of the files with only renames are in
TBR, as those changes are trivial.
Putting to CQ now.
Vaclav

http://codereview.chromium.org/10832003/diff/1/net/base/upload_data.h
File net/base/upload_data.h (right):

http://codereview.chromium.org/10832003/diff/1/net/base/upload_data.h#newcode230
net/base/upload_data.h:230: std::vector<Element>* elements() {
On 2012/07/27 20:28:56, gavinp wrote:
> A suggestion: can we rename this one elements_mutable()?  Having both versions
> overloaded is acceptable within our coding standard, but distinguishing them
> does help readability.

Done.

http://codereview.chromium.org/10832003/diff/1/net/url_request/url_request.h
File net/url_request/url_request.h (right):

http://codereview.chromium.org/10832003/diff/1/net/url_request/url_request.h#...
net/url_request/url_request.h:416: const UploadData* get_upload() const;
On 2012/07/27 20:28:56, gavinp wrote:
> Hrm, I wonder why this method name doesn't meet our coding standard: normally
> hacker_style methods should only be inline simple getters.

Well, I don't know, just copied the style from the non-const getter :). As you
suggest the _mutable name again in hacker_style I understand you don't want me
to change it. If you do, let me know, I can set-up a separate CL for that.
Alternatively to renaming, we could also inline these functions, as there indeed
are just simple getters.

http://codereview.chromium.org/10832003/diff/1/net/url_request/url_request.h#...
net/url_request/url_request.h:417: UploadData* get_upload();
On 2012/07/27 20:28:56, gavinp wrote:
> get_upload_mutable() here, too?

Done.

[commit-bot: I haz the power, 2012-07-28 20:37:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vabr@chromium.org/10832003/13007

[gavinp, 2012-07-28 20:56:41]

On 2012/07/28 20:37:09, vabr (Chromium) wrote:
> Thanks Gavin for the review.
> I did the re-naming you suggested, owners of the files with only renames are
in
> TBR, as those changes are trivial.
> Putting to CQ now.
> Vaclav
> 
> http://codereview.chromium.org/10832003/diff/1/net/base/upload_data.h
> File net/base/upload_data.h (right):
> 
>
http://codereview.chromium.org/10832003/diff/1/net/base/upload_data.h#newcode230
> net/base/upload_data.h:230: std::vector<Element>* elements() {
> On 2012/07/27 20:28:56, gavinp wrote:
> > A suggestion: can we rename this one elements_mutable()?  Having both
versions
> > overloaded is acceptable within our coding standard, but distinguishing them
> > does help readability.
> 
> Done.
> 
> http://codereview.chromium.org/10832003/diff/1/net/url_request/url_request.h
> File net/url_request/url_request.h (right):
> 
>
http://codereview.chromium.org/10832003/diff/1/net/url_request/url_request.h#...
> net/url_request/url_request.h:416: const UploadData* get_upload() const;
> On 2012/07/27 20:28:56, gavinp wrote:
> > Hrm, I wonder why this method name doesn't meet our coding standard:
normally
> > hacker_style methods should only be inline simple getters.
> 
> Well, I don't know, just copied the style from the non-const getter :). As you
> suggest the _mutable name again in hacker_style I understand you don't want me
> to change it. If you do, let me know, I can set-up a separate CL for that.
> Alternatively to renaming, we could also inline these functions, as there
indeed
> are just simple getters.

I think you read me right; I was asking a rhetorical question. I think that what
you uploaded is fine. The separate CL for fixing these (and yes, probably
inlining is exactly the answer) is an earnest way to deal with the rhetorical
question, but is by no means required.

Thanks for your CL! Happy hacking.

> 
>
http://codereview.chromium.org/10832003/diff/1/net/url_request/url_request.h#...
> net/url_request/url_request.h:417: UploadData* get_upload();
> On 2012/07/27 20:28:56, gavinp wrote:
> > get_upload_mutable() here, too?
> 
> Done.

[commit-bot: I haz the power, 2012-07-28 22:01:31]

Change committed as 148906