Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: content/browser/download/download_manager_impl.cc

Issue 10831412: Added some cancel/close tab tests to SavePackage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated some comments. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_manager_impl.cc
diff --git a/content/browser/download/download_manager_impl.cc b/content/browser/download/download_manager_impl.cc
index e7797609128771fe351aa8a1b3a58a1bff377726..8f2b1755bf318c26319cdaea66aa6487d1681ed1 100644
--- a/content/browser/download/download_manager_impl.cc
+++ b/content/browser/download/download_manager_impl.cc
@@ -559,9 +559,7 @@ DownloadItemImpl* DownloadManagerImpl::CreateSavePackageDownloadItem(
new SavePageData(download);
DCHECK(SavePageData::Get(download));
- // TODO(benjhayden): Fire OnDownloadCreated for SavePackage downloads when
- // we're comfortable with the user interacting with them.
- // FOR_EACH_OBSERVER(Observer, observers_, OnDownloadCreated(this, download));
+ FOR_EACH_OBSERVER(Observer, observers_, OnDownloadCreated(this, download));
// Will notify the observer in the callback.
if (delegate_)
« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698