Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 10831379: Disable audio when audio capturer is not available on the host platform. (Closed)

Created:
8 years, 4 months ago by Sergey Ulanov
Modified:
8 years, 4 months ago
Reviewers:
Wez, kxing
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Disable audio when audio capturer is not available on the host platform. Currently audio channel is created even when the host doesn't have a capturer. This causes a DCHECK in the audio scheduler. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152245

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M remoting/host/chromoting_host.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
8 years, 4 months ago (2012-08-17 18:24:05 UTC) #1
Wez
lgtm http://codereview.chromium.org/10831379/diff/7001/remoting/host/chromoting_host.cc File remoting/host/chromoting_host.cc (right): http://codereview.chromium.org/10831379/diff/7001/remoting/host/chromoting_host.cc#newcode87 remoting/host/chromoting_host.cc:87: // we don't have audio capturer. nit: "Disable ...
8 years, 4 months ago (2012-08-18 00:51:09 UTC) #2
Sergey Ulanov
http://codereview.chromium.org/10831379/diff/7001/remoting/host/chromoting_host.cc File remoting/host/chromoting_host.cc (right): http://codereview.chromium.org/10831379/diff/7001/remoting/host/chromoting_host.cc#newcode87 remoting/host/chromoting_host.cc:87: // we don't have audio capturer. On 2012/08/18 00:51:09, ...
8 years, 4 months ago (2012-08-18 01:43:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10831379/7002
8 years, 4 months ago (2012-08-18 01:44:07 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-18 03:08:05 UTC) #5
Try job failure for 10831379-7002 (retry) on linux_rel for step
"interactive_ui_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698