Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2118)

Unified Diff: chrome/browser/extensions/api/system_info_cpu/system_info_cpu_api.h

Issue 10831353: Add a generic template for system info provider (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Simplify the SystemInfoProvider template code Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/system_info_cpu/system_info_cpu_api.h
diff --git a/chrome/browser/extensions/api/system_info_cpu/system_info_cpu_api.h b/chrome/browser/extensions/api/system_info_cpu/system_info_cpu_api.h
index 46fcbd34ed1d3a1789035ae3efc1d114d5504202..dd91051f7bea78665710b96cec715526b061d593 100644
--- a/chrome/browser/extensions/api/system_info_cpu/system_info_cpu_api.h
+++ b/chrome/browser/extensions/api/system_info_cpu/system_info_cpu_api.h
@@ -5,11 +5,10 @@
#define CHROME_BROWSER_EXTENSIONS_API_SYSTEM_INFO_CPU_SYSTEM_INFO_CPU_API_H_
#include "chrome/browser/extensions/extension_function.h"
+#include "chrome/common/extensions/api/experimental_system_info_cpu.h"
namespace extensions {
-class CpuInfoProvider;
-
class SystemInfoCpuGetFunction : public AsyncExtensionFunction {
public:
DECLARE_EXTENSION_FUNCTION_NAME("experimental.systemInfo.cpu.get");
@@ -18,12 +17,8 @@ class SystemInfoCpuGetFunction : public AsyncExtensionFunction {
private:
virtual ~SystemInfoCpuGetFunction();
virtual bool RunImpl() OVERRIDE;
- void WorkOnFileThread();
- void RespondOnUIThread(bool success);
- void GetCpuInfoOnFileThread();
-
- // The CpuInfoProvider instance, lives on FILE thread.
- CpuInfoProvider* provider_;
+ void OnGetCpuInfoCompleted(
+ const api::experimental_system_info_cpu::CpuInfo& info, bool success);
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698