Add --disable-oobe-animation flag to disable OOBE animation on slow hardware

Add --disable-oobe-animation flag to disable OOBE animation on slow hardware

BUG=142724
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152060

[Ivan Korotkov, 2012-08-15 11:01:28]

lgtm

https://chromiumcodereview.appspot.com/10831325/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/background/ash_user_wallpaper_delegate.cc (right):

https://chromiumcodereview.appspot.com/10831325/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/background/ash_user_wallpaper_delegate.cc:55: //
kDisableOobeAnimation disables OOBE animation too for slow hardware.
|kDisableOobeAnimation| disables OOBE animation for slow hardware as well.

https://chromiumcodereview.appspot.com/10831325/diff/1/chrome/common/chrome_s...
File chrome/common/chrome_switches.cc (right):

https://chromiumcodereview.appspot.com/10831325/diff/1/chrome/common/chrome_s...
chrome/common/chrome_switches.cc:1381: const char kDisableOobeAnimation[]       
= "disable-oobe-animation";
Align by =, please.

[Dmitry Polukhin, 2012-08-15 12:13:31]

+ satorux@ for OWNER review in/chrome/browser/chromeos
+ sky@ for OWNER review in chrome/common

https://chromiumcodereview.appspot.com/10831325/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/background/ash_user_wallpaper_delegate.cc (right):

https://chromiumcodereview.appspot.com/10831325/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/background/ash_user_wallpaper_delegate.cc:55: //
kDisableOobeAnimation disables OOBE animation too for slow hardware.
On 2012/08/15 11:01:28, Ivan Korotkov wrote:
> |kDisableOobeAnimation| disables OOBE animation for slow hardware as well.

Done.

https://chromiumcodereview.appspot.com/10831325/diff/1/chrome/common/chrome_s...
File chrome/common/chrome_switches.cc (right):

https://chromiumcodereview.appspot.com/10831325/diff/1/chrome/common/chrome_s...
chrome/common/chrome_switches.cc:1381: const char kDisableOobeAnimation[]       
= "disable-oobe-animation";
On 2012/08/15 11:01:28, Ivan Korotkov wrote:
> Align by =, please.

Done.

[sky, 2012-08-15 15:18:36]

https://chromiumcodereview.appspot.com/10831325/diff/8001/chrome/common/chrom...
File chrome/common/chrome_switches.h (right):

https://chromiumcodereview.appspot.com/10831325/diff/8001/chrome/common/chrom...
chrome/common/chrome_switches.h:374: extern const char
kDisableLoginAnimations[];
Keep these sorted.

[satorux1, 2012-08-15 15:47:17]

chromeos/background LGTM

but I'd suggest to add OWNERS to chromeos/background directory. Per git log,
nkostylev@ and bshe@ would be the owners there?

[Dmitry Polukhin, 2012-08-15 17:31:50]

PTAL

There is no OWNERS in chrome/browser/chromeos/background and bshe@ is not an
owner in chrome/browser/chromeos.

http://codereview.chromium.org/10831325/diff/8001/chrome/common/chrome_switch...
File chrome/common/chrome_switches.h (right):

http://codereview.chromium.org/10831325/diff/8001/chrome/common/chrome_switch...
chrome/common/chrome_switches.h:374: extern const char
kDisableLoginAnimations[];
On 2012/08/15 15:18:36, sky wrote:
> Keep these sorted.

Done.

[satorux1, 2012-08-15 17:35:46]

On 2012/08/15 17:31:50, Dmitry Polukhin wrote:
> PTAL
> 
> There is no OWNERS in chrome/browser/chromeos/background and bshe@ is not an
> owner in chrome/browser/chromeos.

I was suggesting to add one. You can add it in this patch, or do it in a
separate patch. It's ok for bshe to be in
chrome/browser/chromeos/background/OWNERS, without being in the OWNERS in the
parent directory.

> 
>
http://codereview.chromium.org/10831325/diff/8001/chrome/common/chrome_switch...
> File chrome/common/chrome_switches.h (right):
> 
>
http://codereview.chromium.org/10831325/diff/8001/chrome/common/chrome_switch...
> chrome/common/chrome_switches.h:374: extern const char
> kDisableLoginAnimations[];
> On 2012/08/15 15:18:36, sky wrote:
> > Keep these sorted.
> 
> Done.

[bshe, 2012-08-15 22:30:08]

On 2012/08/15 17:35:46, satorux1 wrote:
> On 2012/08/15 17:31:50, Dmitry Polukhin wrote:
> > PTAL
> > 
> > There is no OWNERS in chrome/browser/chromeos/background and bshe@ is not an
> > owner in chrome/browser/chromeos.
> 
> I was suggesting to add one. You can add it in this patch, or do it in a
> separate patch. It's ok for bshe to be in
> chrome/browser/chromeos/background/OWNERS, without being in the OWNERS in the
> parent directory.
> 
> > 
> >
>
http://codereview.chromium.org/10831325/diff/8001/chrome/common/chrome_switch...
> > File chrome/common/chrome_switches.h (right):
> > 
> >
>
http://codereview.chromium.org/10831325/diff/8001/chrome/common/chrome_switch...
> > chrome/common/chrome_switches.h:374: extern const char
> > kDisableLoginAnimations[];
> > On 2012/08/15 15:18:36, sky wrote:
> > > Keep these sorted.
> > 
> > Done.

just drive-by:
Sorry, I dont know much context about this issue. But this new flag looks very
similar to --disable-boot-animation flag. If we just want to disable oobe
animation on a slow device, I believe we can reuse --disable-boot-animation
flag. no?

[Dmitry Polukhin, 2012-08-16 06:19:34]

On 2012/08/15 22:30:08, bshe wrote:
> just drive-by:
> Sorry, I dont know much context about this issue. But this new flag looks very
> similar to --disable-boot-animation flag. If we just want to disable oobe
> animation on a slow device, I believe we can reuse --disable-boot-animation
> flag. no?

Yes, it is very similar but if we re-use --disable-boot-animation it will also
disable the animation for Alex and ZGB that have no issue with black splash.

[commit-bot: I haz the power, 2012-08-17 06:08:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/10831325/10001

[commit-bot: I haz the power, 2012-08-17 06:08:23]

Presubmit check for 10831325-10001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 1.4s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Dmitry Polukhin, 2012-08-17 06:11:03]

Scott, this cl misses OWNER review in chrome directory. We would like to commit
it see comments in https://gerrit.chromium.org/gerrit/#/c/30405/

[Dmitry Polukhin, 2012-08-17 06:47:33]

On 2012/08/17 06:11:03, Dmitry Polukhin wrote:
> Scott, this cl misses OWNER review in chrome directory. We would like to
commit
> it see comments in https://gerrit.chromium.org/gerrit/#/c/30405/

Because we are limited in time with the bug and all comments are resolved, I'll
commit with TBR for changes in chrome/ directory.