Upstream Android NTP resources.

Upstream Android NTP resources.

This upstreams the Android new tab page html/js/css resources
wholesale.  The NTP will be rewritten using Android UI elements in the
near future, so we'd like to upstream this with minimal changes.

BUG=136951
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152008

[newt (away), 2012-08-14 23:54:10]

PTAL, Evan.  Thank you!

As mentioned in the CL description, we're planning to rewrite the NTP using
Android UI elements.  So I don't think there's much value in scrutinizing this
too closely, hence the single large CL.

[Evan Stade, 2012-08-15 00:08:26]

rubbery LGTM

[commit-bot: I haz the power, 2012-08-15 00:24:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/10831317/1

[commit-bot: I haz the power, 2012-08-15 00:25:20]

Presubmit check for 10831317-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  chrome/browser/resources/ntp_android/opentabs_tablet.css, line 41, 88 chars \
  chrome/browser/resources/ntp_android/opentabs_tablet.css, line 57, 95 chars

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 4.0s to calculate.

[newt (away), 2012-08-15 00:32:50]

Adding thakis for browser_resources.grd.  Thanks.

[Nico, 2012-08-15 02:34:37]

lgtm

lgtm

[commit-bot: I haz the power, 2012-08-15 02:34:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/10831317/1

[commit-bot: I haz the power, 2012-08-15 02:35:07]

Presubmit check for 10831317-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  chrome/browser/resources/ntp_android/opentabs_tablet.css, line 41, 88 chars \
  chrome/browser/resources/ntp_android/opentabs_tablet.css, line 57, 95 chars

Presubmit checks took 3.6s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-08-15 04:08:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/10831317/14002

[commit-bot: I haz the power, 2012-08-15 04:22:11]

Try job failure for 10831317-14002 (retry) on mac_rel for step "runhooks".
It's a second try, previously, step "runhooks" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[newt (away), 2012-08-15 18:30:35]

Is it possible that the try server is not picking up the image files (and hence
failing during the gyp step)?  Gyp runs fine locally, and the "missing" image
file is clearly there...

[Ted C, 2012-08-15 18:31:54]

Try servers do not pick up binary files (this bit me in the past for android
resource images that break the R.java generation)...and thus hate you.  Sorry
:-(

On 2012/08/15 18:30:35, newt wrote:
> Is it possible that the try server is not picking up the image files (and
hence
> failing during the gyp step)?  Gyp runs fine locally, and the "missing" image
> file is clearly there...

[Nico, 2012-08-15 18:33:47]

On Wed, Aug 15, 2012 at 11:31 AM,  <tedchoc@chromium.org> wrote:
> Try servers do not pick up binary files (this bit me in the past for android
> resource images that break the R.java generation)...and thus hate you.

Right, usually you'd land all binary files in a TBR cl first with a
description like "binary files for <codereview link of actual change>"
and then send a tryjob for just the grd change.

> Sorry
> :-(
>
>
> On 2012/08/15 18:30:35, newt wrote:
>>
>> Is it possible that the try server is not picking up the image files (and
>
> hence
>>
>> failing during the gyp step)?  Gyp runs fine locally, and the "missing"
>> image
>> file is clearly there...
>
>
>
>
> http://codereview.chromium.org/10831317/

[commit-bot: I haz the power, 2012-08-16 22:20:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/10831317/2012

[commit-bot: I haz the power, 2012-08-17 00:31:56]

Change committed as 152008