Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 10831312: Remove direct DBus calls from OutputConfigurator (Closed)

Created:
8 years, 4 months ago by disher
Modified:
8 years, 4 months ago
Reviewers:
satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove direct DBus calls from OutputConfigurator Remove DBus signal to power_manager::kUseNewMonitorConfigSignal since it is no longer needed by the other side (this used to be required but it was only meant to be temporary and the other side no longer listens for the signal). Move DBus call to power_manager::kSetIsProjectingMethod into the DBus PowerManagerClient class which is where the other methods in the IPC interface live. BUG=chromium:142039 TEST=Manually tested on Lumpy and verified that adding/removing displays results in powerd receiving a SetIsProjecting call. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151894

Patch Set 1 #

Patch Set 2 : Delete DEPS as it is no longer needed #

Total comments: 2

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -38 lines) Patch
M chromeos/dbus/mock_power_manager_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/dbus/power_manager_client.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chromeos/dbus/power_manager_client.cc View 2 chunks +13 lines, -0 lines 0 comments Download
D chromeos/display/DEPS View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/display/output_configurator.cc View 1 2 3 chunks +3 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
satorux1
http://codereview.chromium.org/10831312/diff/6001/chromeos/display/output_configurator.cc File chromeos/display/output_configurator.cc (left): http://codereview.chromium.org/10831312/diff/6001/chromeos/display/output_configurator.cc#oldcode239 chromeos/display/output_configurator.cc:239: // control. oh this code was unnecessary?
8 years, 4 months ago (2012-08-14 18:44:53 UTC) #1
disher
https://chromiumcodereview.appspot.com/10831312/diff/6001/chromeos/display/output_configurator.cc File chromeos/display/output_configurator.cc (left): https://chromiumcodereview.appspot.com/10831312/diff/6001/chromeos/display/output_configurator.cc#oldcode239 chromeos/display/output_configurator.cc:239: // control. On 2012/08/14 18:44:53, satorux1 wrote: > oh ...
8 years, 4 months ago (2012-08-14 19:27:31 UTC) #2
satorux1
LGTM. Thank you for fixing this.
8 years, 4 months ago (2012-08-14 20:46:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/disher@chromium.org/10831312/2002
8 years, 4 months ago (2012-08-16 13:43:49 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 15:07:09 UTC) #5
Change committed as 151894

Powered by Google App Engine
This is Rietveld 408576698