Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 10831279: Check for space before storing files to the cache. (Closed)

Created:
8 years, 4 months ago by Zachary Kuznia
Modified:
8 years, 4 months ago
Reviewers:
kinaba
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Check for space before storing files to the cache. R=kinaba@chromium.org BUG=126980 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151238

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
M chrome/browser/chromeos/gdata/gdata_cache.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_cache_unittest.cc View 14 chunks +58 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Zachary Kuznia
8 years, 4 months ago (2012-08-13 04:51:01 UTC) #1
kinaba
http://codereview.chromium.org/10831279/diff/1/chrome/browser/chromeos/gdata/gdata_cache.cc File chrome/browser/chromeos/gdata/gdata_cache.cc (right): http://codereview.chromium.org/10831279/diff/1/chrome/browser/chromeos/gdata/gdata_cache.cc#newcode834 chrome/browser/chromeos/gdata/gdata_cache.cc:834: I think we can wrap whole these checks with: ...
8 years, 4 months ago (2012-08-13 05:06:30 UTC) #2
Zachary Kuznia
http://codereview.chromium.org/10831279/diff/1/chrome/browser/chromeos/gdata/gdata_cache.cc File chrome/browser/chromeos/gdata/gdata_cache.cc (right): http://codereview.chromium.org/10831279/diff/1/chrome/browser/chromeos/gdata/gdata_cache.cc#newcode834 chrome/browser/chromeos/gdata/gdata_cache.cc:834: On 2012/08/13 05:06:30, kinaba wrote: > I think we ...
8 years, 4 months ago (2012-08-13 05:12:26 UTC) #3
kinaba
lgtm
8 years, 4 months ago (2012-08-13 05:21:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/10831279/5001
8 years, 4 months ago (2012-08-13 05:37:49 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-13 08:35:24 UTC) #6
Change committed as 151238

Powered by Google App Engine
This is Rietveld 408576698