net/test/base_test_server.cc - Issue 10831277: [net] Change factory methods for HostResolver and HostCache to return a scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/base_test_server.cc

Issue 10831277: [net] Change factory methods for HostResolver and HostCache to return a scoped_ptr (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove unnecessary initialization; respond to review Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/test/base_test_server.cc

diff --git a/net/test/base_test_server.cc b/net/test/base_test_server.cc

index 7ca7f7ffc550715557ea48060cb06d25896c3484..d13d57cfd21e66084ba886cdd2bdd5b8224c2bfb 100644

--- a/net/test/base_test_server.cc

+++ b/net/test/base_test_server.cc

@@ -168,10 +168,7 @@ std::string BaseTestServer::GetScheme() const {

bool BaseTestServer::GetAddressList(AddressList* address_list) const {

DCHECK(address_list);

- scoped_ptr<HostResolver> resolver(

- CreateSystemHostResolver(HostResolver::kDefaultParallelism,

- HostResolver::kDefaultRetryAttempts,

- NULL));

+ scoped_ptr<HostResolver> resolver(HostResolver::CreateDefaultResolver(NULL));

HostResolver::RequestInfo info(host_port_pair_);

TestCompletionCallback callback;

int rv = resolver->Resolve(info, address_list, callback.callback(), NULL,

« no previous file with comments | « net/spdy/spdy_test_util_spdy3.cc ('k') | net/tools/fetch/fetch_client.cc » ('j') | no next file with comments »