net/spdy/spdy_test_util_spdy2.cc - Issue 10831277: [net] Change factory methods for HostResolver and HostCache to return a scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_test_util_spdy2.cc

Issue 10831277: [net] Change factory methods for HostResolver and HostCache to return a scoped_ptr (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove unnecessary initialization; respond to review Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_test_util_spdy2.cc

diff --git a/net/spdy/spdy_test_util_spdy2.cc b/net/spdy/spdy_test_util_spdy2.cc

index e5cbac2b7ab3d662ecca486a8af728d7c8dff2e5..476d73c6c0775106cb366ba137cf03df1543643c 100644

--- a/net/spdy/spdy_test_util_spdy2.cc

+++ b/net/spdy/spdy_test_util_spdy2.cc

@@ -968,7 +968,7 @@ HttpNetworkSession* SpdySessionDependencies::SpdyCreateSessionDeterministic(

SpdyURLRequestContext::SpdyURLRequestContext()

: ALLOW_THIS_IN_INITIALIZER_LIST(storage_(this)) {

- storage_.set_host_resolver(new MockHostResolver());

+ storage_.set_host_resolver(scoped_ptr<HostResolver>(new MockHostResolver));

storage_.set_cert_verifier(new MockCertVerifier);

storage_.set_proxy_service(ProxyService::CreateDirect());

storage_.set_ssl_config_service(new SSLConfigServiceDefaults);

« no previous file with comments | « net/proxy/proxy_script_fetcher_impl_unittest.cc ('k') | net/spdy/spdy_test_util_spdy3.cc » ('j') | no next file with comments »