Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: net/base/host_resolver_impl_unittest.cc

Issue 10831277: [net] Change factory methods for HostResolver and HostCache to return a scoped_ptr (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove unnecessary initialization; respond to review Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/host_resolver_impl.cc ('k') | net/base/mapped_host_resolver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/host_resolver_impl_unittest.cc
diff --git a/net/base/host_resolver_impl_unittest.cc b/net/base/host_resolver_impl_unittest.cc
index 527e91b7764a2d9a0ee73de8b3a1427d30251a65..0bad1d357dce681a4f048bfd1537f7018d392b14 100644
--- a/net/base/host_resolver_impl_unittest.cc
+++ b/net/base/host_resolver_impl_unittest.cc
@@ -435,7 +435,7 @@ class HostResolverImplTest : public testing::Test {
HostCache::CreateDefaultCache(),
DefaultLimits(),
DefaultParams(proc_),
- scoped_ptr<DnsClient>(NULL),
+ scoped_ptr<DnsClient>(),
NULL));
}
@@ -449,7 +449,7 @@ class HostResolverImplTest : public testing::Test {
HostCache::CreateDefaultCache(),
limits,
params,
- scoped_ptr<DnsClient>(NULL),
+ scoped_ptr<DnsClient>(),
NULL));
}
@@ -758,10 +758,10 @@ TEST_F(HostResolverImplTest, StartWithinCallback) {
// Turn off caching for this host resolver.
resolver_.reset(new HostResolverImpl(
- NULL,
+ scoped_ptr<HostCache>(),
DefaultLimits(),
DefaultParams(proc_),
- scoped_ptr<DnsClient>(NULL),
+ scoped_ptr<DnsClient>(),
NULL));
for (size_t i = 0; i < 4; ++i) {
@@ -1198,7 +1198,7 @@ TEST_F(HostResolverImplTest, MultipleAttempts) {
new HostResolverImpl(HostCache::CreateDefaultCache(),
DefaultLimits(),
params,
- scoped_ptr<DnsClient>(NULL),
+ scoped_ptr<DnsClient>(),
NULL));
// Resolve "host1".
« no previous file with comments | « net/base/host_resolver_impl.cc ('k') | net/base/mapped_host_resolver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698