net/base/host_resolver_impl.h - Issue 10831277: [net] Change factory methods for HostResolver and HostCache to return a scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/host_resolver_impl.h

Issue 10831277: [net] Change factory methods for HostResolver and HostCache to return a scoped_ptr (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove unnecessary initialization; respond to review Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/host_resolver_impl.h

diff --git a/net/base/host_resolver_impl.h b/net/base/host_resolver_impl.h

index 8d0f781ec9d97f6432cfc9124210d21776ade6a2..1bc9b6944a7fa5249a000fb89d512be37fd41ff0 100644

--- a/net/base/host_resolver_impl.h

+++ b/net/base/host_resolver_impl.h

@@ -115,7 +115,7 @@ class NET_EXPORT HostResolverImpl

// |net_log| must remain valid for the life of the HostResolverImpl.

// TODO(szym): change to scoped_ptr<HostCache>.

- HostResolverImpl(HostCache* cache,

+ HostResolverImpl(scoped_ptr<HostCache> cache,

const PrioritizedDispatcher::Limits& job_limits,

const ProcTaskParams& proc_params,

scoped_ptr<DnsClient> dns_client,

« no previous file with comments | « net/base/host_resolver.cc ('k') | net/base/host_resolver_impl.cc » ('j') | no next file with comments »