Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9969)

Unified Diff: chrome/browser/printing/print_view_manager.cc

Issue 10831272: Adding basic Metro Print Metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding crbug.com Issue ID for TODOs. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | printing/printing_context_win.cc » ('j') | printing/printing_context_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_view_manager.cc
diff --git a/chrome/browser/printing/print_view_manager.cc b/chrome/browser/printing/print_view_manager.cc
index 09213d26f3a1ffd03b000e6abdf733f59a8b5ebb..e8fce2e324d0343496070e86bd8343f92f3f3471 100644
--- a/chrome/browser/printing/print_view_manager.cc
+++ b/chrome/browser/printing/print_view_manager.cc
@@ -9,6 +9,7 @@
#include "base/bind.h"
#include "base/lazy_instance.h"
#include "base/memory/scoped_ptr.h"
+#include "base/metrics/histogram.h"
#include "base/timer.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/browser_process.h"
@@ -109,6 +110,9 @@ bool PrintViewManager::AdvancedPrintNow() {
}
bool PrintViewManager::PrintToDestination() {
+ // TODO(mad): Remove this once we can send user metrics from the metro driver.
+ // crbug.com/142330
+ UMA_HISTOGRAM_ENUMERATION("Metro.Print", 0, 2);
Ilya Sherman 2012/08/13 22:34:00 nit: Please use named constants from an enum rathe
// TODO(mad): Use a passed in destination interface instead.
g_browser_process->print_job_manager()->SetPrintDestination(
printing::CreatePrintDestination());
« no previous file with comments | « no previous file | printing/printing_context_win.cc » ('j') | printing/printing_context_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698