Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: remoting/base/stoppable.cc

Issue 10831271: [Chromoting] Adding uiAccess='true' to the remoting_me2me_host.exe's manifest as it is required to … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR feedback. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/base/stoppable.h" 5 #include "remoting/base/stoppable.h"
6 6
7 #include "base/message_loop.h" 7 #include "base/message_loop.h"
8 #include "base/single_thread_task_runner.h" 8 #include "base/single_thread_task_runner.h"
9 9
10 namespace remoting { 10 namespace remoting {
11 11
12 Stoppable::Stoppable( 12 Stoppable::Stoppable(
13 scoped_refptr<base::SingleThreadTaskRunner> task_runner, 13 scoped_refptr<base::SingleThreadTaskRunner> task_runner,
14 const base::Closure& stopped_callback) 14 const base::Closure& stopped_callback)
15 : state_(kRunning), 15 : state_(kRunning),
16 stopped_callback_(stopped_callback), 16 stopped_callback_(stopped_callback),
17 task_runner_(task_runner) { 17 task_runner_(task_runner) {
18 } 18 }
19 19
20 Stoppable::~Stoppable() { 20 Stoppable::~Stoppable() {
21 DCHECK_EQ(state_, kStopped); 21 // Failing this check means that the object implementing |Stoppable| hasn't
22 // been shutdown correctly.
Wez 2012/08/15 23:22:20 Isn't that implicit in the CHECK itself? You're si
alexeypa (please no reviews) 2012/08/15 23:55:50 I removed the comment.
23 CHECK_EQ(state_, kStopped);
22 } 24 }
23 25
24 void Stoppable::Stop() { 26 void Stoppable::Stop() {
25 DCHECK(task_runner_->BelongsToCurrentThread()); 27 DCHECK(task_runner_->BelongsToCurrentThread());
26 28
27 if (state_ == kRunning) { 29 if (state_ == kRunning) {
28 state_ = kStopping; 30 state_ = kStopping;
29 } 31 }
30 32
31 // DoStop() can be called multiple times. 33 // DoStop() can be called multiple times.
32 DoStop(); 34 DoStop();
33 } 35 }
34 36
35 void Stoppable::CompleteStopping() { 37 void Stoppable::CompleteStopping() {
36 DCHECK(task_runner_->BelongsToCurrentThread()); 38 DCHECK(task_runner_->BelongsToCurrentThread());
37 DCHECK_EQ(state_, kStopping); 39 DCHECK_EQ(state_, kStopping);
38 40
39 state_ = kStopped; 41 state_ = kStopped;
40 task_runner_->PostTask(FROM_HERE, stopped_callback_); 42 task_runner_->PostTask(FROM_HERE, stopped_callback_);
41 } 43 }
42 44
43 } // namespace remoting 45 } // namespace remoting
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698