[Chromoting] Adding uiAccess='true' to the remoting_me2me_host.exe's manifest as it is required to …

base/message_pump_win.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_MESSAGE_PUMP_WIN_H_
 #define BASE_MESSAGE_PUMP_WIN_H_
 
 #include <windows.h>
 
 #include <list>
@@ skipping 278 matching lines @@
 
   // MessagePump methods:
   virtual void ScheduleWork();
   virtual void ScheduleDelayedWork(const TimeTicks& delayed_work_time);
 
   // Register the handler to be used when asynchronous IO for the given file
   // completes. The registration persists as long as |file_handle| is valid, so
   // |handler| must be valid as long as there is pending IO for the given file.
   void RegisterIOHandler(HANDLE file_handle, IOHandler* handler);
 
+  // Register the handler to be used to process job events. The registration
+  // persists as long as the job object is live, so |handler| must be valid
+  // until the job object is destoyed.
+  bool RegisterJobObject(HANDLE job_handle, IOHandler* handler);
+
   // Waits for the next IO completion that should be processed by |filter|, for
   // up to |timeout| milliseconds. Return true if any IO operation completed,
   // regardless of the involved handler, and false if the timeout expired. If
   // the completion port received any message and the involved IO handler
   // matches |filter|, the callback is called before returning from this code;
   // if the handler is not the one that we are looking for, the callback will
   // be postponed for another time, so reentrancy problems can be avoided.
   // External use of this method should be reserved for the rare case when the
   // caller is willing to allow pausing regular task dispatching on this thread.
   bool WaitForIOCompletion(DWORD timeout, IOHandler* filter);
 
   void AddIOObserver(IOObserver* obs);
   void RemoveIOObserver(IOObserver* obs);
 
  private:
   struct IOItem {
     IOHandler* handler;
     IOContext* context;
     DWORD bytes_transfered;
     DWORD error;
+
+    // |true| if |context| is a valid IOContext pointer.
+    bool has_context;

[jar (doing other things), 2012/08/11 02:30:01]

With a pointer, it is confusing to have a bool, and a pointer.  Perhaps a better
name, such as:

has_valid_io_context

would help to make this more readable.

[alexeypa (please no reviews), 2012/08/13 15:15:14]

Done.

   };
 
   virtual void DoRunLoop();
   void WaitForWork();
   bool MatchCompletedIOItem(IOHandler* filter, IOItem* item);
   bool GetIOItem(DWORD timeout, IOItem* item);
   bool ProcessInternalIOItem(const IOItem& item);
   void WillProcessIOEvent();
   void DidProcessIOEvent();
 
+  // Converts an IOHandler pointer to a completion port key. |has_context|
+  // specifies whether complation packets will have valid OVERLAPPED pointers.

[jar (doing other things), 2012/08/11 02:30:01]

typo: complation

[alexeypa (please no reviews), 2012/08/13 15:15:14]

Done.

+  static ULONG_PTR HandlerToKey(IOHandler* handler, bool has_context);
+
+  // Converts a completion port key to an IOHandler pointer.
+  static IOHandler* KeyToHandler(ULONG_PTR key, bool* has_context_out);
+
   // The completion port associated with this thread.
   win::ScopedHandle port_;
   // This list will be empty almost always. It stores IO completions that have
   // not been delivered yet because somebody was doing cleanup.
   std::list<IOItem> completed_io_;
 
   ObserverList<IOObserver> io_observers_;
 };
 
 }  // namespace base
 
 #endif  // BASE_MESSAGE_PUMP_WIN_H_