[Chromoting] Adding uiAccess='true' to the remoting_me2me_host.exe's manifest as it is required to …

base/message_loop.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_MESSAGE_LOOP_H_
 #define BASE_MESSAGE_LOOP_H_
 
 #include <queue>
 #include <string>
 
@@ skipping 613 matching lines @@
   void AddIOObserver(IOObserver* io_observer) {
     pump_io()->AddIOObserver(io_observer);
   }
 
   void RemoveIOObserver(IOObserver* io_observer) {
     pump_io()->RemoveIOObserver(io_observer);
   }
 
 #if defined(OS_WIN)
   // Please see MessagePumpWin for definitions of these methods.
-  void RegisterIOHandler(HANDLE file_handle, IOHandler* handler);
+  void RegisterIOHandler(HANDLE file, IOHandler* handler);
+  bool RegisterJobObject(HANDLE job, IOHandler* handler);

[jar (doing other things), 2012/08/11 02:30:01]

Please add comment explaining that the return boolean value is meant to be.

Comment for line 636 would also be appreciated.

[alexeypa (please no reviews), 2012/08/13 15:15:14]

Done.

[jar (doing other things), 2012/08/15 23:42:03]

I didn't see the added comments.

On 2012/08/13 15:15:14, alexeypa wrote:

[alexeypa (please no reviews), 2012/08/15 23:55:50]

rvargas@ asked me not to copy-paste documentation. The added comments are in
message_pump_win.h.

   bool WaitForIOCompletion(DWORD timeout, IOHandler* filter);
 
  protected:
   // TODO(rvargas): Make this platform independent.
   base::MessagePumpForIO* pump_io() {
     return static_cast<base::MessagePumpForIO*>(pump_.get());
   }
 
 #elif defined(OS_POSIX)
   // Please see MessagePumpLibevent for definition.
@@ skipping 10 matching lines @@
 #endif  // defined(OS_POSIX)
 };
 
 // Do not add any member variables to MessageLoopForIO!  This is important b/c
 // MessageLoopForIO is often allocated via MessageLoop(TYPE_IO).  Any extra
 // data that you need should be stored on the MessageLoop's pump_ instance.
 COMPILE_ASSERT(sizeof(MessageLoop) == sizeof(MessageLoopForIO),
                MessageLoopForIO_should_not_have_extra_member_variables);
 
 #endif  // BASE_MESSAGE_LOOP_H_