Extensions Docs Server: BranchUtility not fetching branch numbers correctly (fixed)

chrome/common/extensions/docs/server2/integration_test.py

Index: chrome/common/extensions/docs/server2/integration_test.py
diff --git a/chrome/common/extensions/docs/server2/integration_test.py b/chrome/common/extensions/docs/server2/integration_test.py
index 392337d28dc610a1fa66d7b2c3dd8bf621a679ec..73c00fe0505ea2b2f82867ac3698838dfc41b535 100755
--- a/chrome/common/extensions/docs/server2/integration_test.py
+++ b/chrome/common/extensions/docs/server2/integration_test.py
@@ -14,6 +14,11 @@ from handler import Handler
 KNOWN_FAILURES = [
 ]
 
+def _FakeGetBranchNumberForChannelName(channel_name):
+  return 'local'
+handler.BRANCH_UTILITY.GetBranchNumberForChannelName = (
+    _FakeGetBranchNumberForChannelName)

[not at google - send to devlin, 2012/08/13 00:53:00]

I alluded to something like this in a bug report I just replied to.

A more integration-test kind of thing to do would be to set up a fake server
which knows about the protocol. I.e. a fake omaha server kind of thing (you can
just make it return canned responses that you get from omaha).

The trick is getting the server to actually point to that "server" instead of
the real server.

I'd try doing this by putting the knowledge in the fake urlfetch implementation
(in appengine_wrappers). Rather than that returning a FakeUrlFetch, allow it to
be configured. I'm imagining an interface like


--- integration_test.py

import appengine_wrappers
import url_constants

class FakeOmahaProxy(object):
  def fetch(self, url):
    return "insert_canned_response_here"

class FakeSubversionServer(object):
  _base_pattern = re.compile(r"chrome/common/extensions/(.*)$")
  def fetch(self, url):
    # Only the interesting part of the path.
    # ... whatever the local filesystem fetch is.
    return local_fetch('chrome/common/extensions/%s' %
                       _base_pattern.match(url).groups()[0])

appengine_wrappers.ConfigureFakeUrlFetch({
  url_constants.OMAHA_PROXY_URL:  FakeOmahaProxy(),
  "%s/*" % url_constants.SVN_URL: FakeSubversionServer(),
})


--- appengine_wrappers.py

def ConfigureFakeUrlFetch(configuration):
  FAKE_URL_FETCHER_CONFIGURATION = configuration

try:
  import ...
except ImportError:
  class FakeUrlFetch(object):
    def fetch(self, url):
      # TODO: match globs.
      return FAKE_URL_FETCHER_CONFIGURATION[url].fetch(url)
    def create_rpc(self):
      # Return object that eventually just calls fetch()
      # so that the fake fetch implementations can handle it.
    def make_fetch_call(self):
      # ditto

[cduvall, 2012/08/13 21:45:04]

Done.

+
 class _MockResponse(object):
   def __init__(self):
     self.status = 200