Extensions Docs Server: BranchUtility not fetching branch numbers correctly (fixed)

chrome/common/extensions/docs/server2/appengine_wrappers.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This will attempt to import the actual App Engine modules, and if it fails,
 # they will be replaced with fake modules. This is useful during testing.
 try:
   import google.appengine.ext.webapp as webapp
   import google.appengine.api.memcache as memcache
   import google.appengine.api.urlfetch as urlfetch
 except ImportError:
+  import re
+
+  FAKE_URL_FETCHER_CONFIGURATION = None
+
+  def ConfigureFakeUrlFetch(configuration):
+    global FAKE_URL_FETCHER_CONFIGURATION
+    FAKE_URL_FETCHER_CONFIGURATION = dict(
+        (re.compile(k), v) for k, v in configuration.iteritems())
+
+  def GetConfiguration(key):

[not at google - send to devlin, 2012/08/13 22:36:46]

add like

if not FAKE_URL_FETCHER_CONFIGURATION:
  raise ValueError("No fake fetch paths have been configured. "
                   "See ConfigureFakeUrlFetch in appengine_wrappers.py.")

and then add some comment in ConfigureFakeUrlFetch.

also GetConfiguration should be private, right? _GetConfiguration?

[cduvall, 2012/08/13 23:17:22]

Done.

+    for k, v in FAKE_URL_FETCHER_CONFIGURATION.iteritems():
+      if k.match(key):
+        return v
+    return None
+
   class FakeUrlFetch(object):
     """A fake urlfetch module that errors for all method calls.

[not at google - send to devlin, 2012/08/13 22:36:46]

comment is out of date

[cduvall, 2012/08/13 23:17:22]

Done.

     """
+    class _Response(object):
+      def __init__(self, content):
+        self.content = content
+        self.headers = { 'content-type': 'none' }
+        self.status_code = 200
+
+    class _RPC(object):
+      def __init__(self):
+        self.result = None
+
+      def wait(self):
+        pass
+
+      def get_result(self):
+        return self.result
+
     def fetch(self, url):
-      raise NotImplementedError()
+      return self._Response(GetConfiguration(url).fetch(url))
 
     def create_rpc(self):
-      raise NotImplementedError()
+      return self._RPC()
 
-    def make_fetch_call(self):
-      raise NotImplementedError()
+    def make_fetch_call(self, rpc, url):
+      rpc.result = self.fetch(url)
   urlfetch = FakeUrlFetch()
 
   class InMemoryMemcache(object):
     """A memcache that stores items in memory instead of using the memcache
     module.
     """
     def __init__(self):
       self._cache = {}
 
     def set(self, key, value, namespace, time=60):
@@ skipping 13 matching lines @@
 
   # A fake webapp.RequestHandler class for Handler to extend.
   class webapp(object):
     class RequestHandler(object):
       def __init__(self, request, response):
         self.request = request
         self.response = response
 
       def redirect(self, path):
         self.request.path = path