Extensions Docs Server: BranchUtility not fetching branch numbers correctly (fixed)

chrome/common/extensions/docs/server2/handler.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 import sys
 
 from appengine_wrappers import webapp
 from appengine_wrappers import memcache
@@ skipping 21 matching lines @@
 DEFAULT_BRANCH = 'local'
 
 SVN_URL = 'http://src.chromium.org/chrome'
 TRUNK_URL = SVN_URL + '/trunk'
 BRANCH_URL = SVN_URL + '/branches'
 
 OMAHA_PROXY_URL = 'http://omahaproxy.appspot.com/json'
 BRANCH_UTILITY_MEMCACHE = AppEngineMemcache('branch_utility')
 BRANCH_UTILITY = BranchUtility(OMAHA_PROXY_URL,
                                DEFAULT_BRANCH,
-                               AppEngineUrlFetcher(''),
+                               AppEngineUrlFetcher(None),
                                BRANCH_UTILITY_MEMCACHE)
 
 STATIC_DIR_PREFIX = 'docs/server2'
 EXTENSIONS_PATH = 'chrome/common/extensions'
 DOCS_PATH = 'docs'
 API_PATH = 'api'
 INTRO_PATH = DOCS_PATH + '/server2/templates/intros'
 ARTICLE_PATH = DOCS_PATH + '/server2/templates/articles'
 PUBLIC_TEMPLATE_PATH = DOCS_PATH + '/server2/templates/public'
 PRIVATE_TEMPLATE_PATH = DOCS_PATH + '/server2/templates/private'
@@ skipping 45 matching lines @@
       template_data_source_factory,
       example_zipper,
       cache_builder)
   return SERVER_INSTANCES[branch]
 
 def _GetURLFromBranch(branch):
     if branch == 'trunk':
       return TRUNK_URL + '/src'
     return BRANCH_URL + '/' + branch + '/src'
 
+def _CleanBranches():
+  numbers = [BRANCH_UTILITY.GetBranchNumberForChannelName(branch)
+             for branch in ['dev', 'beta', 'stable', 'trunk', 'local']]

[not at google - send to devlin, 2012/08/13 00:53:00]

currently only the branch utility knows what the actual branches are. Let's keep
it that way and put this method on branch utility (like GetAllBranchNumbers).

[cduvall, 2012/08/13 21:45:04]

Done.

+  for key in SERVER_INSTANCES.keys():
+    if key not in numbers:
+      SERVER_INSTANCES.pop(key)
+
 class Handler(webapp.RequestHandler):
   def __init__(self, request, response, local_path=EXTENSIONS_PATH):
     self._local_path = local_path
     super(Handler, self).__init__(request, response)
 
   def _NavigateToPath(self, path):
     channel_name, real_path = BRANCH_UTILITY.SplitChannelNameFromPath(path)
     branch = BRANCH_UTILITY.GetBranchNumberForChannelName(channel_name)
     # TODO: Detect that these are directories and serve index.html out of them.
     if real_path.strip('/') == 'apps':
       real_path = 'apps/index.html'
     if real_path.strip('/') == 'extensions':
       real_path = 'extensions/index.html'
-    # TODO: This leaks Server instances when branch bumps.
+    _CleanBranches()
     _GetInstanceForBranch(branch, self._local_path).Get(real_path,
+                                                        channel_name,

[not at google - send to devlin, 2012/08/13 00:53:00]

why can't this go in the constructor of template_data_source? I.e. pass into
_GetInstanceForBranch and thread through like that.

In fact you wouldn't need to pass branch into there, you could make
_GetInstanceForBranch figure it out for itself.

[cduvall, 2012/08/13 21:45:04]

Done.

                                                         self.request,
                                                         self.response)
 
   def get(self):
     path = self.request.path
     if '_ah/warmup' in path:
       logging.info('Warmup request.')
       if DEFAULT_BRANCH != 'local':
         self._NavigateToPath('trunk/extensions/samples.html')
       self._NavigateToPath('dev/extensions/samples.html')
       self._NavigateToPath('beta/extensions/samples.html')
       self._NavigateToPath('stable/extensions/samples.html')
       return
 
     # Redirect paths like "directory" to "directory/". This is so relative file
     # paths will know to treat this as a directory.
     if os.path.splitext(path)[1] == '' and path[-1] != '/':
       self.redirect(path + '/')
     path = path.replace('/chrome/', '')
     path = path.strip('/')
     self._NavigateToPath(path)