Tidy up ChromotingInstance members a little.

Tidy up ChromotingInstance members a little.
- Group member variables more appropriately.
- Create the input pipeline as member objects rather than separate objects, to remove the need for pointer checks in various places.

TEST=Existing unit-tests. Client plugin continues to work in manual tests.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151680

[Wez, 2012-08-09 23:55:35]

PTAL

[Sergey Ulanov, 2012-08-10 00:30:58]

http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
File remoting/client/plugin/chromoting_instance.cc (right):

http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
remoting/client/plugin/chromoting_instance.cc:160:
mac_key_event_processor_(&input_tracker_),
Does this work properly? mac_key_event_processor_ is a scoped_ptr<> so I think
you meant to create the event processor here. Or make mac_key_event_processor_ a
member instead of scoped_ptr.

http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
File remoting/client/plugin/chromoting_instance.h (right):

http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
remoting/client/plugin/chromoting_instance.h:59: class PepperInputHandler;
remove this line

[Wez, 2012-08-10 20:04:56]

http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
File remoting/client/plugin/chromoting_instance.cc (right):

http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
remoting/client/plugin/chromoting_instance.cc:160:
mac_key_event_processor_(&input_tracker_),
On 2012/08/10 00:30:58, sergeyu wrote:
> Does this work properly? mac_key_event_processor_ is a scoped_ptr<> so I think
> you meant to create the event processor here. Or make mac_key_event_processor_
a
> member instead of scoped_ptr.

Done.

http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
remoting/client/plugin/chromoting_instance.cc:160:
mac_key_event_processor_(&input_tracker_),
On 2012/08/10 00:30:58, sergeyu wrote:
> Does this work properly? mac_key_event_processor_ is a scoped_ptr<> so I think
> you meant to create the event processor here. Or make mac_key_event_processor_
a
> member instead of scoped_ptr.

Did this CL on Linux, so of course missed that this wouldn't build... :(

http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
File remoting/client/plugin/chromoting_instance.h (right):

http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
remoting/client/plugin/chromoting_instance.h:59: class PepperInputHandler;
On 2012/08/10 00:30:58, sergeyu wrote:
> remove this line

Done.

[Wez, 2012-08-13 23:58:01]

On 2012/08/10 20:04:56, Wez wrote:
>
http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
> File remoting/client/plugin/chromoting_instance.cc (right):
> 
>
http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
> remoting/client/plugin/chromoting_instance.cc:160:
> mac_key_event_processor_(&input_tracker_),
> On 2012/08/10 00:30:58, sergeyu wrote:
> > Does this work properly? mac_key_event_processor_ is a scoped_ptr<> so I
think
> > you meant to create the event processor here. Or make
mac_key_event_processor_
> a
> > member instead of scoped_ptr.
> 
> Done.
> 
>
http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
> remoting/client/plugin/chromoting_instance.cc:160:
> mac_key_event_processor_(&input_tracker_),
> On 2012/08/10 00:30:58, sergeyu wrote:
> > Does this work properly? mac_key_event_processor_ is a scoped_ptr<> so I
think
> > you meant to create the event processor here. Or make
mac_key_event_processor_
> a
> > member instead of scoped_ptr.
> 
> Did this CL on Linux, so of course missed that this wouldn't build... :(
> 
>
http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
> File remoting/client/plugin/chromoting_instance.h (right):
> 
>
http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
> remoting/client/plugin/chromoting_instance.h:59: class PepperInputHandler;
> On 2012/08/10 00:30:58, sergeyu wrote:
> > remove this line
> 
> Done.

Ping. ^.^

[Wez, 2012-08-14 17:31:40]

On 2012/08/13 23:58:01, Wez wrote:
> On 2012/08/10 20:04:56, Wez wrote:
> >
>
http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
> > File remoting/client/plugin/chromoting_instance.cc (right):
> > 
> >
>
http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
> > remoting/client/plugin/chromoting_instance.cc:160:
> > mac_key_event_processor_(&input_tracker_),
> > On 2012/08/10 00:30:58, sergeyu wrote:
> > > Does this work properly? mac_key_event_processor_ is a scoped_ptr<> so I
> think
> > > you meant to create the event processor here. Or make
> mac_key_event_processor_
> > a
> > > member instead of scoped_ptr.
> > 
> > Done.
> > 
> >
>
http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
> > remoting/client/plugin/chromoting_instance.cc:160:
> > mac_key_event_processor_(&input_tracker_),
> > On 2012/08/10 00:30:58, sergeyu wrote:
> > > Does this work properly? mac_key_event_processor_ is a scoped_ptr<> so I
> think
> > > you meant to create the event processor here. Or make
> mac_key_event_processor_
> > a
> > > member instead of scoped_ptr.
> > 
> > Did this CL on Linux, so of course missed that this wouldn't build... :(
> > 
> >
>
http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
> > File remoting/client/plugin/chromoting_instance.h (right):
> > 
> >
>
http://codereview.chromium.org/10831221/diff/1/remoting/client/plugin/chromot...
> > remoting/client/plugin/chromoting_instance.h:59: class PepperInputHandler;
> > On 2012/08/10 00:30:58, sergeyu wrote:
> > > remove this line
> > 
> > Done.
> 
> Ping. ^.^

Ping!

[Sergey Ulanov, 2012-08-14 18:52:05]

LGTM. sorry for delay

[commit-bot: I haz the power, 2012-08-14 18:59:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10831221/3002

[commit-bot: I haz the power, 2012-08-14 20:50:54]

Try job failure for 10831221-3002 (retry) (previous was lost) on linux_rel for
step "interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-14 21:01:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10831221/3002

[commit-bot: I haz the power, 2012-08-14 22:51:18]

Try job failure for 10831221-3002 (retry) on win_rel for step "runhooks".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-14 23:12:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10831221/3002

[commit-bot: I haz the power, 2012-08-15 02:51:06]

Try job failure for 10831221-3002 (retry) on linux_chromeos for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-15 07:02:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10831221/3002

[commit-bot: I haz the power, 2012-08-15 10:19:02]

Change committed as 151680