Issue 10831204: Fix for number of ChromeOS browser_tests that were failing in BVTs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831204: Fix for number of ChromeOS browser_tests that were failing in BVTs. (Closed)

Created:
8 years, 4 months ago by zel

Modified:
8 years, 4 months ago

Reviewers:
James Hawkins, DaveMoore, sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix for number of ChromeOS browser_tests that were failing in BVTs. Added extra logs for tracing test web server failures in browser_tests. TEST=make sure ChromeOS BVT browser_tests pass BUG=131915 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150659

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
M	chrome/browser/chromeos/preferences.cc	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/browser_options_handler.cc	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/test/browser_test_utils.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

8 years, 4 months ago (2012-08-08 21:07:24 UTC) #4

LGTM

http://codereview.chromium.org/10831204/diff/2001/chrome/browser/ui/webui/opt...
File chrome/browser/ui/webui/options2/browser_options_handler.cc (right):

http://codereview.chromium.org/10831204/diff/2001/chrome/browser/ui/webui/opt...
chrome/browser/ui/webui/options2/browser_options_handler.cc:367:
chromeos::UserManager::Get()->GetLoggedInUser().email() : "");
nit: "" -> std::string().

Expand Messages | Collapse Messages