Change behavior when clicking on a network from auto-connect to show options.

chrome/browser/resources/options2/chromeos/network_list.js

Index: chrome/browser/resources/options2/chromeos/network_list.js
diff --git a/chrome/browser/resources/options2/chromeos/network_list.js b/chrome/browser/resources/options2/chromeos/network_list.js
index 0bde4df8bc58a765cdb2b50bd0352218d38e60f2..d2fcbbb620ead52008afe23830fa371b9957fdb5 100644
--- a/chrome/browser/resources/options2/chromeos/network_list.js
+++ b/chrome/browser/resources/options2/chromeos/network_list.js
@@ -415,9 +415,6 @@ cr.define('options.network', function() {
       if (policyManaged)
         this.showManagedNetworkIndicator();
 
-      // TODO(kevers): Add default icon for VPN when disconnected or in the
-      // process of connecting.
-
       if (activeMenu_ == this.getMenuName_()) {
         // Menu is already showing and needs to be updated. Explicitly calling
         // show menu will force the existing menu to be replaced.  The call
@@ -460,8 +457,7 @@ cr.define('options.network', function() {
             options.Preferences.setBooleanPref(
                 'cros.signed.data_roaming_enabled',
                 !enableDataRoaming_);
-            // Force revalidation of the menu the next time it is
-            // displayed.
+            // Force revalidation of the menu the next time it is displayed.
             this.menu_ = null;
           };
         }
@@ -487,26 +483,9 @@ cr.define('options.network', function() {
       if (list) {
         for (var i = 0; i < list.length; i++) {
           var data = list[i];
-          if (!data.connected && !data.connecting) {
-            if (data.networkType != Constants.TYPE_ETHERNET) {
-              if (data.networkType == Constants.TYPE_CELLULAR) {
-                // Test if cellular network has an activated data plan.
-                var activate = data.needs_new_plan ||
-                   (data.activation_state !=
-                   Constants.ACTIVATION_STATE_ACTIVATED &&
-                   data.activation_state !=
-                   Constants.ACTIVATION_STATE_ACTIVATING);
-                var cmd = activate ? 'activate' : 'connect';
-                this.createConnectCallback_(networkGroup, data, cmd);
-              } else {
-                this.createConnectCallback_(networkGroup, data);
-              }
-              empty = false;
-            }
-          } else if (data.connected) {
-            addendum.push({label: loadTimeData.getString('networkOptions'),
-                           command: 'options',
-                           data: data});
+          this.createNetworkOptionsCallback_(networkGroup, data);
+          empty = false;

[James Hawkins, 2012/08/02 21:36:45]

Huh, this seems unnecessary.  Can't you initialize |empty| to !!list.length
above?

[kevers, 2012/08/03 13:10:13]

Yes, logic can be simplified now that there is no conditional pruning.

+          if (data.connected) {
             if (data.networkType == Constants.TYPE_VPN) {
               // Add separator
               addendum.push({});
@@ -515,13 +494,6 @@ cr.define('options.network', function() {
                              command: 'disconnect',
                              data: data});
             }
-            if (data.networkType != Constants.TYPE_ETHERNET) {
-              var onlineMessage = this.ownerDocument.createElement('div');
-              onlineMessage.textContent =
-                  loadTimeData.getString('networkOnline');
-              onlineMessage.className = 'network-menu-header';
-              menu.insertBefore(onlineMessage, menu.firstChild);
-            }
           }
         }
       }
@@ -694,39 +666,24 @@ cr.define('options.network', function() {
     },
 
     /**
-     * Adds a menu item for connecting to a network.
-     * @param {!Element} menu Parent menu.
+     * Adds a menu item for showing network details.
+     * @param {!Element} parent The parent element.
      * @param {Object} data Description of the network.
-     * @param {string=} opt_connect Optional connection method.
      * @private
      */
-    createConnectCallback_: function(menu, data, opt_connect) {
-      var cmd = opt_connect ? opt_connect : 'connect';
-      var label = data.networkName;
-      if (cmd == 'activate') {
-        label = loadTimeData.getString('activateNetwork');
-        label = label.replace('$1', data.networkName);
-      }
-      var menuItem = this.createCallback_(menu,
+    createNetworkOptionsCallback_: function(parent, data) {
+      var menuItem = this.createCallback_(parent,

[James Hawkins, 2012/08/02 21:36:45]

Optional nit: Condense parameters to save lines.

[kevers, 2012/08/03 13:10:13]

Done.

                                           data,
-                                          label,
-                                          cmd);
+                                          data.networkName,
+                                          'options');
       menuItem.style.backgroundImage = url(data.iconURL);
-
       if (data.policyManaged)
         menuItem.appendChild(new ManagedNetworkIndicator());
-
-      var optionsButton = this.ownerDocument.createElement('div');
-      optionsButton.className = 'network-options-button';
-      var type = String(data.networkType);
-      var path = data.servicePath;
-      optionsButton.addEventListener('click', function(event) {
-        event.stopPropagation();
-        chrome.send('networkCommand',
-                    [type, path, 'options']);
-        closeMenu_();
-      });
-      menuItem.appendChild(optionsButton);
+      if (data.connected || data.connecting) {
+        var label = menuItem.getElementsByClassName(
+            'network-menu-item-label')[0];
+        label.classList.add('active-network');
+      }
     }
   };