Change behavior when clicking on a network from auto-connect to show options.

Change behavior when clicking on a network from auto-connect to show options.

BUG=138291, 127457
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149880

[kevers, 2012-08-02 21:34:14]

Hi James,

Can you please have a look at this CL.  Addresses touch-friendliness of the
network menus.  The network options button was not touch-friendly.  Getting rid
of the button by changing the default behavior when selecting a network from
auto-connect/activate to show details fixes the problem.  The details dialog has
a connect/disconnect/activate button based on current state.

[James Hawkins, 2012-08-02 21:36:45]

http://codereview.chromium.org/10831140/diff/1/chrome/browser/resources/optio...
File chrome/browser/resources/options2/chromeos/network_list.js (right):

http://codereview.chromium.org/10831140/diff/1/chrome/browser/resources/optio...
chrome/browser/resources/options2/chromeos/network_list.js:487: empty = false;
Huh, this seems unnecessary.  Can't you initialize |empty| to !!list.length
above?

http://codereview.chromium.org/10831140/diff/1/chrome/browser/resources/optio...
chrome/browser/resources/options2/chromeos/network_list.js:675: var menuItem =
this.createCallback_(parent,
Optional nit: Condense parameters to save lines.

[kevers, 2012-08-03 13:10:12]

http://codereview.chromium.org/10831140/diff/1/chrome/browser/resources/optio...
File chrome/browser/resources/options2/chromeos/network_list.js (right):

http://codereview.chromium.org/10831140/diff/1/chrome/browser/resources/optio...
chrome/browser/resources/options2/chromeos/network_list.js:487: empty = false;
On 2012/08/02 21:36:45, James Hawkins wrote:
> Huh, this seems unnecessary.  Can't you initialize |empty| to !!list.length
> above?

Yes, logic can be simplified now that there is no conditional pruning.

http://codereview.chromium.org/10831140/diff/1/chrome/browser/resources/optio...
chrome/browser/resources/options2/chromeos/network_list.js:675: var menuItem =
this.createCallback_(parent,
On 2012/08/02 21:36:45, James Hawkins wrote:
> Optional nit: Condense parameters to save lines.

Done.

[James Hawkins, 2012-08-03 16:00:05]

lgtm

[commit-bot: I haz the power, 2012-08-03 16:49:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/10831140/2002

[commit-bot: I haz the power, 2012-08-03 18:47:30]

Change committed as 149880