Issue 10831135: aura: Fix hiding the cursor on touch events.

Issue 10831135: aura: Fix hiding the cursor on touch events. (Closed)

Created:
8 years, 4 months ago by sadrul

Modified:
8 years, 4 months ago

Reviewers:
DaveMoore, sky, Ben Goodger (Google)

CC:
chromium-reviews, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura: Fix hiding the cursor on touch events. Touching on any window, whether currently active or not, should hide the mouse cursor. This regressed in r147456. BUG=140257 TEST=move the mouse to show the cursor, then touch the chrome window title. the cursor should become invisible. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149870

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -8 lines)			Patch
M	ui/aura/shared/compound_event_filter.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/aura/shared/compound_event_filter.cc	View	4 chunks	+10 lines, -6 lines	0 comments	Download
M	ui/aura/shared/compound_event_filter_unittest.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

sadrul

On 2012/08/02 19:17:07, sadrul wrote: > Thanks! > > +sky@ for OWNERS ping!

8 years, 4 months ago (2012-08-02 23:56:59 UTC) #4

sky

LGTM Question though, do we send any sort of event when the cursor is hidden?

8 years, 4 months ago (2012-08-03 17:33:19 UTC) #6

sadrul

On 2012/08/03 17:33:19, sky wrote: > LGTM > Question though, do we send any sort ...

8 years, 4 months ago (2012-08-03 17:37:09 UTC) #7

sky

8 years, 4 months ago (2012-08-03 17:52:06 UTC) #8

On Fri, Aug 3, 2012 at 10:37 AM,  <sadrul@chromium.org> wrote:
> On 2012/08/03 17:33:19, sky wrote:
>>
>> LGTM
>> Question though, do we send any sort of event when the cursor is hidden?
>
>
> We currently do not. There are some bugs related to hidden cursors (136057,
> 118173), so perhaps we will have an event for this.
>
> http://codereview.chromium.org/10831135/

Indeed. Things like buttons need some sort of event so they know not
to stay in a hover state.

  -Scott

Expand Messages | Collapse Messages