chrome/browser/autocomplete/history_contents_provider_unittest.cc - Issue 10831062: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/history_contents_provider_unittest.cc

Issue 10831062: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/history_contents_provider.cc ('k') | chrome/browser/ui/bookmarks/bookmark_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/history_contents_provider_unittest.cc

===================================================================

--- chrome/browser/autocomplete/history_contents_provider_unittest.cc (revision 148782)

+++ chrome/browser/autocomplete/history_contents_provider_unittest.cc (working copy)

@@ -11,6 +11,7 @@

#include "chrome/browser/autocomplete/autocomplete_match.h"

#include "chrome/browser/autocomplete/autocomplete_provider_listener.h"

#include "chrome/browser/bookmarks/bookmark_model.h"

+#include "chrome/browser/bookmarks/bookmark_model_factory.h"

#include "chrome/browser/bookmarks/bookmark_utils.h"

#include "chrome/browser/history/history.h"

#include "chrome/browser/history/history_service_factory.h"

@@ -200,9 +201,10 @@

// Add a bookmark.

GURL bookmark_url("http://www.google.com/4");

- bookmark_utils::AddIfNotBookmarked(profile()->GetBookmarkModel(),

- bookmark_url,

- ASCIIToUTF16("bar"));

+ bookmark_utils::AddIfNotBookmarked(

+ BookmarkModelFactory::GetForProfile(profile()),

+ bookmark_url,

+ ASCIIToUTF16("bar"));

// Ask for synchronous. This should only get the bookmark.

AutocompleteInput sync_input(ASCIIToUTF16("bar"), string16(), true, false,

@@ -259,9 +261,10 @@

// Bookmark a history item.

GURL bookmark_url(test_entries[2].url);