debugd: Add GetNetworkInterfaces functionality.

chromeos/dbus/debug_daemon_client.h

Index: chromeos/dbus/debug_daemon_client.h
diff --git a/chromeos/dbus/debug_daemon_client.h b/chromeos/dbus/debug_daemon_client.h
index 2cc7fc230ff08337217a7f1e8e5e57072a4b095b..42beaea0758e2a3cb5e66637e5e6feacbcd400a5 100644
--- a/chromeos/dbus/debug_daemon_client.h
+++ b/chromeos/dbus/debug_daemon_client.h
@@ -59,6 +59,11 @@ class CHROMEOS_EXPORT DebugDaemonClient {
 
   virtual void GetModemStatus(const GetModemStatusCallback& callback) = 0;
 
+  typedef base::Callback<void(bool succeeded, const std::string& status)>

[satorux1, 2012/07/31 20:36:52]

how does |status| look like? Could you add some comment?

[hshi1, 2012/07/31 21:32:02]

The |status| is a json containing a fairly complicated dictionary of
dictionaries. The detailed structure is documented in chromeos
platform/debugd/src/heplers/netif.cc). Would this comment suffice, or shall I
cross-reference the cros source file?

On 2012/07/31 20:36:52, satorux1 wrote:

[satorux1, 2012/07/31 21:35:45]

Would be nice to add a pointer to the documentation. http://goo.gl/ may be
useful to shorten the link

[hshi1, 2012/07/31 21:44:45]

Done.

+      GetInterfacesCallback;
+
+  virtual void GetInterfaces(const GetInterfacesCallback& callback) = 0;

[satorux1, 2012/07/31 20:36:52]

the function comment is missing here and elsewhere too! We should at least have
one here.


I guess  GetNetworkInterfaces would be a better name.

[hshi1, 2012/07/31 21:32:02]

Done.

On 2012/07/31 20:36:52, satorux1 wrote:

+
   typedef base::Callback<void(bool succeeded,
                               const std::map<std::string, std::string>& logs)>
       GetAllLogsCallback;