debugd: Add GetNetworkInterfaces functionality.

chromeos/dbus/debug_daemon_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_DEBUG_DAEMON_CLIENT_H_
 #define CHROMEOS_DBUS_DEBUG_DAEMON_CLIENT_H_
 
 #include "base/callback.h"
 #include "base/platform_file.h"
 #include "base/memory/ref_counted_memory.h"
@@ skipping 41 matching lines @@
   typedef base::Callback<void(bool succeeded, const std::string& status)>
       GetNetworkStatusCallback;
 
   virtual void GetNetworkStatus(const GetNetworkStatusCallback& callback) = 0;
 
   typedef base::Callback<void(bool succeeded, const std::string& status)>
       GetModemStatusCallback;
 
   virtual void GetModemStatus(const GetModemStatusCallback& callback) = 0;
 
+  typedef base::Callback<void(bool succeeded, const std::string& status)>

[satorux1, 2012/07/31 20:36:52]

how does |status| look like? Could you add some comment?

[hshi1, 2012/07/31 21:32:02]

The |status| is a json containing a fairly complicated dictionary of
dictionaries. The detailed structure is documented in chromeos
platform/debugd/src/heplers/netif.cc). Would this comment suffice, or shall I
cross-reference the cros source file?

On 2012/07/31 20:36:52, satorux1 wrote:

[satorux1, 2012/07/31 21:35:45]

Would be nice to add a pointer to the documentation. http://goo.gl/ may be
useful to shorten the link

[hshi1, 2012/07/31 21:44:45]

Done.

+      GetInterfacesCallback;
+
+  virtual void GetInterfaces(const GetInterfacesCallback& callback) = 0;

[satorux1, 2012/07/31 20:36:52]

the function comment is missing here and elsewhere too! We should at least have
one here.


I guess  GetNetworkInterfaces would be a better name.

[hshi1, 2012/07/31 21:32:02]

Done.

On 2012/07/31 20:36:52, satorux1 wrote:

+
   typedef base::Callback<void(bool succeeded,
                               const std::map<std::string, std::string>& logs)>
       GetAllLogsCallback;
   virtual void GetAllLogs(const GetAllLogsCallback& callback) = 0;
 
   // Requests to start system/kernel tracing.
   virtual void StartSystemTracing() = 0;
 
   // Called once RequestStopSystemTracing() is complete. Takes one parameter:
   // - result: the data collected while tracing was active
@@ skipping 15 matching lines @@
   // Create() should be used instead.
   DebugDaemonClient();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DebugDaemonClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_DEBUG_DAEMON_CLIENT_H_