Move BuildCallGetter/BuildCallSetter up in the call chain.

src/hydrogen.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1070 matching lines @@
                                NilValue nil);
 
   HStringCharCodeAt* BuildStringCharCodeAt(HValue* context,
                                            HValue* string,
                                            HValue* index);
   HInstruction* BuildBinaryOperation(BinaryOperation* expr,
                                      HValue* left,
                                      HValue* right);
   HInstruction* BuildIncrement(bool returns_original_input,
                                CountOperation* expr);
   HLoadNamedField* BuildLoadNamedField(HValue* object,

[Michael Starzinger, 2012/07/27 09:19:23]

I know it's not part of your change, but can we move the declaration of this
method into the block of property-related BuildFoo() methods?

[Sven Panne, 2012/07/27 09:42:40]

Done.

                                        Handle<Map> map,
                                        LookupResult* result,
                                        bool smi_and_map_check);
   HInstruction* BuildLoadNamedGeneric(HValue* object,

[Michael Starzinger, 2012/07/27 09:19:23]

Likewise.

[Sven Panne, 2012/07/27 09:42:40]

Done.

                                       Handle<String> name,
                                       Property* expr);
   HInstruction* BuildLoadKeyedGeneric(HValue* object, HValue* key);

[Michael Starzinger, 2012/07/27 09:19:23]

Likewise.

[Sven Panne, 2012/07/27 09:42:40]

Done.

   HInstruction* BuildExternalArrayElementAccess(
       HValue* external_elements,
       HValue* checked_key,
       HValue* val,
       HValue* dependency,
       ElementsKind elements_kind,
       bool is_store);
   HInstruction* BuildFastElementAccess(HValue* elements,
                                        HValue* checked_key,
                                        HValue* val,
@@ skipping 35 matching lines @@
                                    Expression* expr,
                                    int ast_id,
                                    int position,
                                    bool is_store,
                                    bool* has_side_effects);
 
   HInstruction* BuildCallGetter(HValue* object,
                                 Handle<Map> map,
                                 Handle<AccessorPair> accessors,
                                 Handle<JSObject> holder);
+  bool LookupAccessorPair(Handle<Map> map,

[Michael Starzinger, 2012/07/27 09:19:23]

Can we have a short comment what this method does and about the semantics of the
return value. Also I would move it up a few lines in front of the block of
property-related BuildFoo() methods.

[Sven Panne, 2012/07/27 09:42:40]

Done.

+                          Handle<String> name,
+                          Handle<AccessorPair>* accessors,
+                          Handle<JSObject>* holder);
   HInstruction* BuildLoadNamedMonomorphic(HValue* object,
                                           Handle<String> name,
                                           Property* expr,
                                           Handle<Map> map);
   HInstruction* BuildCallSetter(HValue* object,
                                 HValue* value,
                                 Handle<Map> map,
                                 Handle<AccessorPair> accessors,
                                 Handle<JSObject> holder);
   HInstruction* BuildStoreNamedMonomorphic(HValue* object,
@@ skipping 292 matching lines @@
   const char* filename_;
   HeapStringAllocator string_allocator_;
   StringStream trace_;
   int indent_;
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_HYDROGEN_H_