Skip unknown channel configurations when parsing session config.

remoting/protocol/content_description.cc

Index: remoting/protocol/content_description.cc
diff --git a/remoting/protocol/content_description.cc b/remoting/protocol/content_description.cc
index 0cd7ce441d56bf781ebc87a72f63f090341e3da9..6fb7d5a6d07a5989f7a6fa709fcdaf7c4ab85140 100644
--- a/remoting/protocol/content_description.cc
+++ b/remoting/protocol/content_description.cc
@@ -235,10 +235,10 @@ bool ContentDescription::ParseChannelConfigs(
   const XmlElement* child = element->FirstNamed(tag);
   while (child) {
     ChannelConfig channel_config;
-    if (!ParseChannelConfig(child, codec_required, &channel_config))
-      return false;
-    configs->push_back(channel_config);
-    child = child->NextNamed(tag);
+    if (ParseChannelConfig(child, codec_required, &channel_config)) {
+      configs->push_back(channel_config);
+      child = child->NextNamed(tag);

[simonmorris, 2012/07/26 16:11:06]

The loop will go infinite if ParseChannelConfig ever returns false.

A unit test would have caught this error.

[Sergey Ulanov, 2012/07/26 22:54:45]

Fixed.
And added unittest this time.

+    }
   }
   if (optional && configs->empty()) {
       // If there's no mention of the tag, implicitly assume